fix(notes): improve NEW badge UX and add star button loading state#22
Merged
fix(notes): improve NEW badge UX and add star button loading state#22
Conversation
- Reduce NEW badge size (9px font, minimal padding) with right spacing - Remove badge on any title change instead of only from defaults - Fix cross-tab sync for badge removal via WebSocket - Update notes list when manually refreshing note from editor - Add delayed spinner (500ms) to star button in editor panel - Expose setNotes from useNotes hook for manual refresh updates
Contributor
|
🎉 This PR is included in version 1.28.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enhanced the NEW badge user experience and added visual feedback for starring notes.
Changes
NEW Badge Improvements
Star Button Enhancement
Technical Improvements
setNotesfrom useNotes hook to support manual refresh updatesTesting
Files Changed
src/components/editor/hooks/useEditorEffects.tssrc/components/editor/index.tsxsrc/components/layout/MainLayout.tsxsrc/components/notes/NotesPanel/NoteCard.tsxsrc/components/notes/NotesPanel/index.tsxsrc/hooks/useNotes.tssrc/hooks/useNotesOperations.tssrc/hooks/useNotesSync.tssrc/lib/api/api.tssrc/types/layout.tssrc/types/note.ts