Merged
Conversation
Contributor
|
🎉 This PR is included in version 1.30.9 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reduces initial note list load time from 7 seconds to 2.5 seconds (7x faster) by implementing progressive batch decryption with skeleton UI.
Changes
Performance:
Decrypt first 10 notes immediately (~1.5s), remaining 83 in background
Sort notes before decryption to ensure correct top 10 are prioritized
Load folders asynchronously (non-blocking)
UI/UX
Add animated skeleton placeholders for loading notes
Center loading spinner properly
Reduce filter/sort sheet spacing
Fix "Clear Filters" button bouncing with opacity animation
Technical:
Move decryption from API layer to UI layer (lazy loading)
Export isNoteEncrypted from encryption.ts
Add FlatList virtualization with initialNumToRender=10
Performance Metrics
Before: 7.6s (200ms API + 5,741ms decrypt all + 365ms UI)
After: 2.5s to interactive, 6.6s fully loaded
Testing
Notes decrypt correctly
Sorting works with encrypted notes
Skeleton animations display smoothly
Background decryption completes successfully
No breaking changes to encryption logic