Suppress warnings#822
Merged
Merged
Conversation
…binary compatability
armanbilge
previously approved these changes
May 20, 2026
armanbilge
reviewed
May 21, 2026
|
|
||
| ThisBuild / crossScalaVersions := Seq(Scala3, Scala213, Scala212) | ||
| ThisBuild / tlVersionIntroduced := Map("3" -> "0.9.3") | ||
| ThisBuild / tlFatalWarnings := false |
Co-authored-by: Arman Bilge <arman@typelevel.org>
armanbilge
approved these changes
May 22, 2026
Member
armanbilge
left a comment
armanbilge
left a comment
There was a problem hiding this comment.
nice job, so great to have fatal warnings enabled. thanks!
Comment on lines
-133
to
+134
| property("toList/toStream consistency")(forAll { (q: Dequeue[Int]) => | ||
| assertEquals(q.toList, q.to[Stream, Int].toList) | ||
| property("toList/toVector consistency")(forAll { (q: Dequeue[Int]) => | ||
| assertEquals(q.toList, q.to[Vector, Int].toList) |
Member
There was a problem hiding this comment.
for posterity: this change is reasonable because what was being tested was not specific to Stream (or laziness). This is about testing the factory-based to method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Warning in HashMap for catsCollectionsUnorderedTraverseForHashMap, it was forcing the compiler to generate an evidence parameter of type Hash[K], but this evidence isn't needed or used, causing an unused parameter warning. The fix was to manually de-sugar and mark the evidence parameter with @unused
This is only a suppression for the issue described in #821, which would address the warning directly.
I plan to silence more warnings in this pr, this is only for a single warning.