-
-
Notifications
You must be signed in to change notification settings - Fork 108
Suppress warnings #822
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Suppress warnings #822
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
79cf6ed
suppressed warning in catsCollectionsUnorderedTraverseForHashMap from…
loladenney e3188cc
suppressed warning in HashMap for UnorderedTraverse without breaking …
loladenney 740f583
forgot to run formatter
loladenney bac6bbf
accidentally clicked newline after running the formatter last time
loladenney 71d1fda
supressed warnings concerning compose
loladenney 1bd24d5
two more warnings eliminated
loladenney d60d90f
forgot to remove commented out code
loladenney eeea87f
fixed warning in doc generation
loladenney a0e1f99
Update tests/src/test/scala/cats/collections/DequeueSuite.scala
loladenney 2a6620a
fixed more warning in doc
loladenney File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -130,8 +130,8 @@ class DequeueSuite extends DisciplineSuite { | |
| assertEquals(q.toList, Foldable[Dequeue].toList(q)) | ||
| }) | ||
|
|
||
| property("toList/toStream consistency")(forAll { (q: Dequeue[Int]) => | ||
| assertEquals(q.toList, q.to[Stream, Int].toList) | ||
| property("toList/toVector consistency")(forAll { (q: Dequeue[Int]) => | ||
| assertEquals(q.toList, q.to[Vector, Int].toList) | ||
|
Comment on lines
-133
to
+134
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. for posterity: this change is reasonable because what was being tested was not specific to |
||
| }) | ||
|
|
||
| property("equality")(forAll { (xs: List[Int]) => | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉