Avoid allocations when calling Resource.liftK#4589
Merged
durban merged 2 commits intotypelevel:series/3.xfrom May 4, 2026
Merged
Avoid allocations when calling Resource.liftK#4589durban merged 2 commits intotypelevel:series/3.xfrom
durban merged 2 commits intotypelevel:series/3.xfrom
Conversation
durban
previously approved these changes
May 1, 2026
Contributor
|
Wait, is this not your commit? |
Contributor
Author
@durban I am not sure what you mean. Of course it's my commit. Please explain. |
Contributor
|
@nmichael44 The github UI is showing both commits as belonging to another user. A certain @neophytos-m. |
Contributor
Author
@durban Same guy :). Sorry, I don't know how that happened. Let me try to fix that. |
nmichael44
force-pushed
the
CreateCachedVersionOfLiftK
branch
from
0f9662c to
c2b358b
Compare
Contributor
Author
@durban Should be fixed now. Please take another look. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a cached version of liftK so avoid allocations when method Resource.liftK is called. This is using the usual trick (relying on erasure).
This is a minor optimization (every little helps), but feel free to close the PR if you don't feel it's worth it.