-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Expand Foldable docs: add sections for collectFirst, findM, foldMapA/M/K, minimumByList, partitionEither #4827
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arnavsharma990
wants to merge
1
commit into
typelevel:main
Choose a base branch
from
arnavsharma990:docs/expand-foldable-page
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+125
−0
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The statement "it cannot short-circuit" is too strong. While
foldMapAdoes not guarantee short-circuiting behavior (unlikefoldMapMwhich guarantees it via the Monad constraint), some Applicative instances likeOptiondo actually short-circuit. The current wording could mislead readers into thinkingfoldMapAwill never short-circuit.Consider rewording to something like: "foldMapA is the Applicative variant — it does not guarantee short-circuiting (though some Applicative instances like Option do), but works in a broader set of contexts."
Alternatively, since the example at line 208 already mentions "foldMapA behaves the same for Option", you could simply say "foldMapA is the Applicative variant — it works in a broader set of contexts but may not short-circuit for all Applicative instances."