Skip to content

refactor(api_call): improve node selection with shuffling #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonbosco merged 3 commits into from
Jun 2, 2025
Merged

refactor(api_call): improve node selection with shuffling #95

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
37fb133
refactor(api_call): improve node selection with shuffling
tharropoulos May 28, 2025
7acd49d
feat(config): add array shuffling on instantiation
tharropoulos May 30, 2025
b875a4f
feat(config): use built-in method when shuffling nodes
tharropoulos Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions src/Lib/Configuration.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,11 @@ class Configuration
*/
private int $logLevel;

/**
* @var bool
*/
private bool $randomizeNodes;

/**
* Configuration constructor.
*
Expand All @@ -83,6 +88,11 @@ public function __construct(array $config)
$this->nodes[] = new Node($node['host'], $node['port'], $node['path'] ?? '', $node['protocol']);
}

$this->randomizeNodes = $config['randomize_nodes'] ?? true;
if ($this->randomizeNodes) {
$this->shuffleNodes();
}

$nearestNode = $config['nearest_node'] ?? null;
$this->nearestNode = null;
if (null !== $nearestNode) {
Expand Down Expand Up @@ -237,4 +247,18 @@ public function getClient(): ClientInterface | HttpMethodsClient
}
return $this->client;
}

/**
* Shuffles the nodes array using Fisher-Yates algorithm
*/
private function shuffleNodes(): void
Comment thread
tharropoulos marked this conversation as resolved.
Outdated
{
$count = count($this->nodes);
for ($i = $count - 1; $i > 0; $i--) {
$j = random_int(0, $i);
$temp = $this->nodes[$i];
$this->nodes[$i] = $this->nodes[$j];
$this->nodes[$j] = $temp;
}
}
}