Skip to content

Fix documentation on using transient services#870

Open
Ryman wants to merge 2 commits into
typestack:developfrom
Ryman:patch-1
Open

Fix documentation on using transient services#870
Ryman wants to merge 2 commits into
typestack:developfrom
Ryman:patch-1

Conversation

@Ryman
Copy link
Copy Markdown

@Ryman Ryman commented Aug 30, 2022

cc #51

Description

The documentation for setting up transient services was incorrect and references a scope property which isn't accepted by the Typescript compiler.

Checklist

  • the pull request title describes what this PR does (not a vague title like Update index.md)
  • the pull request targets the default branch of the repository (develop)
  • the code follows the established code style of the repository
    • npm run prettier:check passes
    • npm run lint:check passes
  • tests are added for the changes I made (if any source code was modified)
  • documentation added or updated
  • I have run the project locally and verified that there are no errors

@Ryman
Copy link
Copy Markdown
Author

Ryman commented Jul 31, 2023

@attilaorosz (pinging you as you're the first human in the review history of master) Can you take a look at this?

@attilaorosz
Copy link
Copy Markdown
Member

The problem is that the latest dev branch has it and the documentation should be aligned with that. Unfortunately it is not released.

@NoNameProvided any plans on a new release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants