Fix documentation on using transient services#870
Open
Ryman wants to merge 2 commits into
Open
Conversation
Author
|
@attilaorosz (pinging you as you're the first human in the review history of master) Can you take a look at this? |
Member
|
The problem is that the latest dev branch has it and the documentation should be aligned with that. Unfortunately it is not released. @NoNameProvided any plans on a new release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc #51
Description
The documentation for setting up transient services was incorrect and references a
scopeproperty which isn't accepted by the Typescript compiler.Checklist
Update index.md)develop)npm run prettier:checkpassesnpm run lint:checkpasses