Use Error Prone 2.37.0

Author: mernst

build.gradle

@@ -62,7 +62,7 @@ ext {
     //  * Temporarily comment out "-Werror" elsewhere in this file
     //  * Repeatedly run `./gradlew clean compileJava` and fix all errors
     //  * Uncomment "-Werror"
-    errorprone : '2.36.0',
+    errorprone : '2.37.0',
   ]
 }
 

checker/src/main/java/org/checkerframework/checker/index/upperbound/UpperBoundTransfer.java

@@ -141,9 +141,7 @@ public TransferResult<CFValue, CFStore> visitAssignment(
         (expNode instanceof TypeCastNode) ? ((TypeCastNode) expNode).getOperand() : expNode;
     // null if right-hand-side is not an array creation expression
     ArrayCreationNode acNode =
-        (expNodeSansCast instanceof ArrayCreationNode)
-            ? acNode = (ArrayCreationNode) expNodeSansCast
-            : null;
+        (expNodeSansCast instanceof ArrayCreationNode) ? (ArrayCreationNode) expNodeSansCast : null;
 
     if (acNode != null) {
       // Right-hand side of assignment is an array creation expression