Don't assign within conditional

Author: mernst

framework/src/main/java/org/checkerframework/common/value/ValueTreeAnnotator.java

@@ -275,22 +275,22 @@ public Void visitTypeCast(TypeCastTree tree, AnnotatedTypeMirror atm) {
 
       TypeMirror newType = atm.getUnderlyingType();
       AnnotationMirror newAnno;
-      Range range;
 
       if (TypesUtils.isString(newType) || newType.getKind() == TypeKind.ARRAY) {
         // Strings and arrays do not allow conversions
         newAnno = oldAnno;
       } else if (atypeFactory.isIntRange(oldAnno)
-          && (range = atypeFactory.getRange(oldAnno))
-              .isWiderThan(ValueAnnotatedTypeFactory.MAX_VALUES)) {
+          && atypeFactory.getRange(oldAnno).isWiderThan(ValueAnnotatedTypeFactory.MAX_VALUES)) {
         Class<?> newClass = TypesUtils.getClassFromType(newType);
         if (newClass == String.class) {
           newAnno = atypeFactory.UNKNOWNVAL;
         } else if (newClass == Boolean.class || newClass == boolean.class) {
           throw new UnsupportedOperationException(
               "ValueAnnotatedTypeFactory: can't convert int to boolean");
         } else {
-          newAnno = atypeFactory.createIntRangeAnnotation(NumberUtils.castRange(newType, range));
+          newAnno =
+              atypeFactory.createIntRangeAnnotation(
+                  NumberUtils.castRange(newType, atypeFactory.getRange(oldAnno)));
         }
       } else {
         List<?> values =