Don't issue warnings on dead code

[smillst]

This should fix the errors in #6221.

[mernst]

Writing this as

        for (Map.Entry<TypeMirror, Set<Block>> entry :
            ((ExceptionBlock) cur).getExceptionalSuccessors().entrySet()) {
          if (!shouldIgnoreException.apply(entry.getKey())) {
            for (Block b : entry.getValue()) {
              if (visited.add(b)) {
                worklist.add(b);
              }
            }
          }
        }

is two lines shorter and I find it easier to read (for example, types are given and there are no lambdas).

I do wish there were a way to bind variables to the parts of the Entry, right in the for statement header.

[mernst]

This could be done with flatMap if you want to make it a one-liner.

[smillst]

flatMap would create a new stream for each block:

getAllBlocks(shouldIgnoreException).stream().flatMap(b -> b.getNodes().stream()).collect(Collectors.toList());

collect would be better:

    getAllBlocks(shouldIgnoreException).stream().collect(ArrayList::new, (list, b) -> list.addAll(b.getNodes()), ArrayList::addAll);

But still it creates a Stream object. I think forEach makes the most sense:

getAllBlocks(shouldIgnoreException).forEach(b -> result.addAll(b.getNodes()));

[mernst]

Any of those, or the current code, is fine with me.

[mernst]

Thanks!