#529: Added database connection details endpoint and response and updated existing endpoint.

[vishalkhode1]

This pull request introduces a new API method to retrieve database connection details for a site instance, along with a dedicated response class and corresponding tests. It also refactors the existing database response to remove connection-specific fields, ensuring a clear separation of concerns between metadata and connection information.

New functionality:

• Added a new method getDatabaseConnection to the SiteInstances endpoint, which returns database connection details for a site instance.
• Introduced a new response class, SiteInstanceDatabaseConnectionResponse, to encapsulate database connection information such as host, username, password, and SSH host.

Refactoring and cleanup:

• Removed connection-specific fields (databaseHost, databaseUserName, databasePassword) from SiteInstanceDatabaseResponse, so it now only contains database metadata.
• Updated the test fixture getSiteInstanceDatabase.json to remove connection fields, reflecting the refactored response.
• Added a new test fixture getSiteInstanceDatabaseConnection.json for the new connection endpoint.

Testing:

• Added new tests for getDatabaseConnection and SiteInstanceDatabaseConnectionResponse, verifying correct parsing and field mapping. [1] [2]
• Updated existing tests to match the refactored structure of SiteInstanceDatabaseResponse. [1] [2]

These changes improve clarity in the API by separating database metadata from connection details and provide comprehensive test coverage for the new and updated functionality.

[vishalkhode1]

@danepowell @typhonius Can you review this ?

[anujkaushal]

@typhonius Could you please grant me access to merge PRs in this repository?

@danepowell Would you be able to support my request?

[danepowell]

@typhonius Could you please grant me access to merge PRs in this repository?

Agreed; @anujkaushal is the new tech lead for Acquia CLI and needs the same access as me.

[typhonius]

@typhonius Could you please grant me access to merge PRs in this repository?

Agreed; @anujkaushal is the new tech lead for Acquia CLI and needs the same access as me.

Thanks all, have invited

[anujkaushal]

@typhonius Could you please grant me access to merge PRs in this repository?

Agreed; @anujkaushal is the new tech lead for Acquia CLI and needs the same access as me.

Thanks all, have invited

Thanks @typhonius