Lint with PHPStan (#29)

Author: tangrufus

.github/workflows/lint.yml

@@ -19,5 +19,3 @@ permissions:
 jobs:
   php:
     uses: typisttech/.github/.github/workflows/lint-php.yml@v3
-    with:
-      phpstan: false

composer.json

@@ -29,7 +29,12 @@
     "require": {
         "php": "^8.3",
         "composer/semver": "^3.4",
-        "guzzlehttp/guzzle": "^7.9"
+        "guzzlehttp/guzzle": "^7.9",
+        "phpstan/extension-installer": "^1.4",
+        "phpstan/phpstan": "^2.1",
+        "phpstan/phpstan-deprecation-rules": "^2.0",
+        "phpstan/phpstan-mockery": "^2.0",
+        "phpstan/phpstan-strict-rules": "^2.0"
     },
     "require-dev": {
         "mockery/mockery": "^1.6",
@@ -48,7 +53,8 @@
     },
     "config": {
         "allow-plugins": {
-            "pestphp/pest-plugin": true
+            "pestphp/pest-plugin": true,
+            "phpstan/extension-installer": true
         },
         "sort-packages": true
     },
@@ -57,6 +63,11 @@
             "curl -o ./tests/Fixtures/vulnerabilities.production.json https://www.wordfence.com/api/intelligence/v2/vulnerabilities/production",
             "curl -o ./tests/Fixtures/vulnerabilities.scanner.json https://www.wordfence.com/api/intelligence/v2/vulnerabilities/scanner"
         ],
+        "lint": [
+            "@composer normalize --dry-run",
+            "pint --test",
+            "phpstan analyse"
+        ],
         "pest": "pest -d memory_limit=512M",
         "pest:e2e": "pest -d memory_limit=512M --group=e2e",
         "pest:feature": "pest -d memory_limit=512M --group=feature",

composer.lock

@@ -0,0 +1,4 @@
+parameters:
+	level: max
+	paths:
+		- src

phpstan.neon

@@ -10,18 +10,28 @@
 
 readonly class AffectedVersionsParser
 {
-    private const string UNKNOWN = 'unknown';
-
     public function __construct(
         private VersionParser $parser = new VersionParser,
     ) {}
 
+    /**
+     * @param  array{from_version?: mixed, from_inclusive?: mixed, to_version?: mixed, to_inclusive?: mixed}[]  $data
+     */
     public function parse(array $data): ?ConstraintInterface
     {
         $constraints = array_map(function (array $affected): ?string {
-            $fromVersion = (string) ($affected['from_version'] ?? self::UNKNOWN);
+            $fromVersion = $affected['from_version'] ?? null;
+            if (! is_string($fromVersion)) {
+                return null;
+            }
+
             $fromInclusive = (bool) ($affected['from_inclusive'] ?? false);
-            $toVersion = (string) ($affected['to_version'] ?? self::UNKNOWN);
+
+            $toVersion = $affected['to_version'] ?? null;
+            if (! is_string($toVersion)) {
+                return null;
+            }
+
             $toInclusive = (bool) ($affected['to_inclusive'] ?? false);
 
             if ($fromVersion === '*' && $toVersion === '*') {
@@ -40,7 +50,7 @@ public function parse(array $data): ?ConstraintInterface
             }
 
             if ($toVersion !== '*') {
-                if (! empty($constraint)) {
+                if ($constraint !== '') {
                     $constraint .= ', ';
                 }
 
@@ -51,23 +61,18 @@ public function parse(array $data): ?ConstraintInterface
             return $constraint;
         }, $data);
 
-        $constraints = array_filter($constraints);
+        $constraints = array_filter($constraints, static fn (?string $c) => $c !== null);
+        $constraints = array_filter($constraints, static fn (string $c) => $c !== '');
         $constraints = array_values($constraints);
         $imploded = implode('||', $constraints);
 
-        if (empty($imploded)) {
-            return null;
-        }
-
-        return $this->parser->parseConstraints($imploded);
+        return $imploded === ''
+            ? null
+            : $this->parser->parseConstraints($imploded);
     }
 
     private function isValid(string $version): bool
     {
-        if ($version === self::UNKNOWN) {
-            return false;
-        }
-
         if ($version === '*') {
             return true;
         }