Add a dark version of vanilla Github theme defalut in Typora#461
Add a dark version of vanilla Github theme defalut in Typora#461bailitaotao wants to merge 1 commit into
Conversation
Just the change of colors, none of the layouts.
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bd572a0822
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| homepage: https://github.com/bailitaotao/typora-github-dark-vanilla-theme | ||
| download: https://github.com/bailitaotao/typora-github-dark-vanilla-theme/blob/main/github-dark-vanilla.css | ||
| author: tim | ||
| thumbnail: https://github.com/bailitaotao/typora-github-dark-vanilla-theme/assets/thumbnail.png |
There was a problem hiding this comment.
thumbnail is set to a full URL, but this site’s templates always prepend /media/thumbnails/ (index.html:12 and _layouts/theme.html:124), so this post renders an invalid image URL like /media/thumbnails/https://... in gallery/detail views. As a result, the new theme entry’s thumbnail will be broken for users unless thumbnail is just a filename that exists under media/thumbnails.
Useful? React with 👍 / 👎.
1 participant
Just the change of colors, none of the layouts.