Skip to content

use-tabler-icons:0.22.0#4774

Closed
zyf722 wants to merge 1 commit intotypst:mainfrom
zyf722:use-tabler-icons-0.22.0
Closed

use-tabler-icons:0.22.0#4774
zyf722 wants to merge 1 commit intotypst:mainfrom
zyf722:use-tabler-icons-0.22.0

Conversation

@zyf722
Copy link
Copy Markdown
Contributor

@zyf722 zyf722 commented May 4, 2026

I am submitting

  • a new package
  • an update for a package

Description:
Update tabler-icons to v3.42.0 with 18 new icons and several fixes (zyf722/typst-tabler-icons#39).

@zyf722 zyf722 temporarily deployed to Package Check May 4, 2026 23:08 — with GitHub Actions Inactive
@typst-package-check typst-package-check Bot added the update A package update. label May 4, 2026
Copy link
Copy Markdown
Member

@saecki saecki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I've left a few comments regarding the readme.

```

#### Manually Install
Just copy all files under [`src`](https://github.com/zyf722/typst-tabler-icons/tree/main/src) to your project and rename them to avoid naming conflicts.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you use a perma link or a link to a specific branch for all linked resources? This will ensure they will always match this version of the package.

This package uses a daily run [Github Actions workflow](https://github.com/zyf722/typst-tabler-icons/tree/main/.github/workflows/build.yml) to keep the library up-to-date with the latest version of Tabler Icons, which internally runs [`scripts/generate.mjs`](https://github.com/zyf722/typst-tabler-icons/tree/main/scripts/generate.mjs) to generate Typst source code of the library and gallery.

## License
[MIT](https://github.com/zyf722/typst-tabler-icons/tree/main/LICENSE)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could just link to the local file

It is strongly recommended to follow the [Conventional Commits](https://www.conventionalcommits.org/en/v1.0.0/) specification when writing commit messages and creating pull requests.

### Github Actions Workflow
This package uses a daily run [Github Actions workflow](https://github.com/zyf722/typst-tabler-icons/tree/main/.github/workflows/build.yml) to keep the library up-to-date with the latest version of Tabler Icons, which internally runs [`scripts/generate.mjs`](https://github.com/zyf722/typst-tabler-icons/tree/main/scripts/generate.mjs) to generate Typst source code of the library and gallery.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have to do this, but I'd consider putting this section inside a deciated CONTRIBUTING.md file.

@saecki saecki added the waiting-on-author Pull request waits on author label May 6, 2026
@zyf722
Copy link
Copy Markdown
Contributor Author

zyf722 commented May 9, 2026

Thanks for the review, @saecki!

I'll close this PR for now and open a new one later with upstream updates and your suggestions.

Edited: New PR #4824

@zyf722 zyf722 closed this May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

update A package update. waiting-on-author Pull request waits on author

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants