Expand hello.xml with namespace information#21
Closed
JKRhb wants to merge 1 commit into
Closed
Conversation
JKRhb
force-pushed
the
update-hello-xml
branch
from
e1e912e to
5b7214f
Compare
Member
|
The inline test in your other PR is actually fine (see typst/typst#7899 (comment)), so I'll close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in typst/typst#7899 (comment), this PR proposes an adjustment of the
hello.xmlfile so that XML tests in the library repository can assert that namespace URIs are handled correctly.With the current implementation in Typst, the processing result of the updated file should be exactly the same as before.
However, I am not sure whether this file is also being used elsewhere. So to be sure, it could make sense to create ahello2.xmlfile instead (if the dependant repositories do not point to a specific commit hash, otherwise the update should be fine).Edit: I just looked up that the
Cargo.tomlfile in thetypstrepository is pointing to a specific commit, so updating the file here should be fine.