Issue 17 filter date timezone comparison

[alexschwantes]

References #17

This pull request may cause a conflict with the changes in #16 ...

[alexschwantes]

Also worth highlighting is that this fix is only for the schedule filter only. I haven't looked at the schedule planner which may also experience the same issues from #10

[hardillb]

I'm testing these changes and I'm getting the wrong output.

The times are all out by 1 hour

evtStart:  Thu Jan 05 2017 15:00:00 GMT+0100 (CET)
evtEnd:  Thu Jan 05 2017 16:00:00 GMT+0100 (CET)
now:  Thu Jan 05 2017 14:22:26 GMT+0100 (CET)

The period marked in the node red is 14:00 to 15:00

I'll keep playing

[hardillb]

I've been having a play on my branch and I think I have a fix for this that works. Can you test the head from here: https://github.com/hardillb/node-red-contrib-simple-weekly-scheduler

[alexschwantes]

Hi, I tested your code but it still fails test 1 and 2 from the issue that I raised.
This is due to the day comparison still comparing in UTC day var day = now.getUTCDay();. If I am in UTC +2 timezone, then it will fail for any event that starts before 2am. This gets exacerbated if you are in a UTC+10 timezone...

I also found out what was wrong with my solution and updated the branch. The following check failed because getDay() was comparing the day of the stored event, which is stored as a date in 2009. So the day comparison worked only by luck on the day that I was testing it..

if(evtEnd.getDay() > day) {
    midnight = 1;
}

I've updated it so that it correctly determines if the event ends at midnight, regardless of the actual date/day.

if(evtEnd.getHours() +  evtEnd.getMinutes() == 0) {

This seems to be working now for me. Are you able to give that a test?

[hardillb]

I can't remember where we left this? can we check what the current state is and if I should work out how to merge it?

[solariz]

sad that this wasn't merged early- have the same problem and can confirm there is a TZ problem.

[hardillb]

@solariz feel free to see if you can clean this up so it doesn't conflict anymore

[k3nz3l]

Hi hardillb, I am experiencing the same issue in version 0.0.14. After changing to daylight savings time, my schedules don't work anymore. Figured out that they are off by 2h now.
Is there any estimate on when this issue will be fixed? I'd be happy to help if necessary.

[hardillb]

@k3nz3l this node (and all others in this org) were written under contract for Tyrrell Systems.

That contract has long since expired, so it is up to them as to if they want to improve/maintain them.