fix(web): stop sticky-merging sidebar summary pending flags

The sidebar was stickily preserving the previous hasPendingApprovals /
hasPendingUserInput / hasActionableProposedPlan flags across every
thread-upserted shell event. This was defensive code from the era when
the shell listing snapshot always reported these flags as false and
relied on detail events to correct them.

After upstream f7fa62a (shell snapshot queries), the server projection
tracks pending_approval_count / pending_user_input_count /
has_actionable_proposed_plan in SQL and updates them in the same
transaction as the corresponding domain event. Every thread-aggregate
event emits a fresh thread-upserted shell event derived from the updated
projection — so the shell event's flags are the authoritative truth.

Keeping the sticky merge caused a ghost "Pending Approval" indicator to
linger in the sidebar forever on threads whose approval had long since
been resolved.

Update the regression tests to reflect the new authority: the shell
event wins. Detail events can still flip flags to true; shell events
can now flip them back to false.

Author: tyulyukov

apps/web/src/store.test.ts

@@ -1342,7 +1342,19 @@ describe("incremental orchestration updates", () => {
   });
 });
 
-describe("shell events preserve detail-authoritative sidebar summary flags", () => {
+describe("shell events are authoritative for sidebar summary flags", () => {
+  // Post-f7fa62aa (shell snapshot queries), the server projection tracks
+  // pendingApprovalCount / pendingUserInputCount / hasActionableProposedPlan
+  // in SQL and updates them in the same transaction that persists the
+  // corresponding domain events. Every thread-aggregate event emits a fresh
+  // thread-upserted shell event derived from the updated projection, so the
+  // shell event's flags are always consistent with the detail stream state.
+  //
+  // Earlier MarCode code stickily preserved prior detail-derived flags across
+  // shell events to guard a theoretical race. That made resolved approvals
+  // linger in the sidebar indefinitely (ghost "Pending Approval" badges on
+  // completed threads). The shell event must win.
+
   function makeThreadUpsertedShellEvent(
     thread: Thread,
     overrides: Partial<OrchestrationThreadShell> = {},
@@ -1374,7 +1386,7 @@ describe("shell events preserve detail-authoritative sidebar summary flags", ()
     };
   }
 
-  it("keeps hasPendingUserInput after a thread-upserted shell event follows a detail activity", () => {
+  it("clears hasPendingUserInput when a later shell event reports the projection resolved it", () => {
     const thread = makeThread();
     const state = makeState(thread);
 
@@ -1424,11 +1436,10 @@ describe("shell events preserve detail-authoritative sidebar summary flags", ()
       localEnvironmentId,
     );
     const afterShellSummary = selectSidebarThreadSummaryByRef(afterShell, ref);
-    expect(afterShellSummary?.hasPendingUserInput).toBe(true);
-    expect(resolveThreadStatusPill({ thread: afterShellSummary! })?.label).toBe("Awaiting Input");
+    expect(afterShellSummary?.hasPendingUserInput).toBe(false);
   });
 
-  it("keeps hasActionableProposedPlan after a thread-upserted shell event follows a detail plan", () => {
+  it("clears hasActionableProposedPlan when a later shell event reports the projection resolved it", () => {
     const thread = makeThread({
       interactionMode: "plan",
       latestTurn: {
@@ -1470,7 +1481,6 @@ describe("shell events preserve detail-authoritative sidebar summary flags", ()
       localEnvironmentId,
     );
     const afterShellSummary = selectSidebarThreadSummaryByRef(afterShell, ref);
-    expect(afterShellSummary?.hasActionableProposedPlan).toBe(true);
-    expect(resolveThreadStatusPill({ thread: afterShellSummary! })?.label).toBe("Plan Ready");
+    expect(afterShellSummary?.hasActionableProposedPlan).toBe(false);
   });
 });

apps/web/src/store.ts

@@ -799,21 +799,12 @@ function writeThreadShellState(
   }
 
   const previousSummary = state.sidebarThreadSummaryById[nextThread.shell.id];
-  const mergedSummary: SidebarThreadSummary = previousSummary
-    ? {
-        ...nextThread.summary,
-        hasPendingApprovals: previousSummary.hasPendingApprovals,
-        hasPendingUserInput: previousSummary.hasPendingUserInput,
-        hasActionableProposedPlan: previousSummary.hasActionableProposedPlan,
-      }
-    : nextThread.summary;
-
-  if (!sidebarThreadSummariesEqual(previousSummary, mergedSummary)) {
+  if (!sidebarThreadSummariesEqual(previousSummary, nextThread.summary)) {
     nextState = {
       ...nextState,
       sidebarThreadSummaryById: {
         ...nextState.sidebarThreadSummaryById,
-        [nextThread.shell.id]: mergedSummary,
+        [nextThread.shell.id]: nextThread.summary,
       },
     };
   }