Improve markdown file link UX (pingdotgg#1956)

Co-authored-by: Julius Marminge <julius0216@outlook.com>

Author: 2 people

apps/web/src/components/ChatMarkdown.browser.tsx

@@ -63,7 +63,7 @@ describe("ChatMarkdown", () => {
     );
 
     try {
-      const link = page.getByRole("link", { name: "PermissionRule.ts:1" });
+      const link = page.getByRole("link", { name: "PermissionRule.ts · L1" });
       await expect.element(link).toBeInTheDocument();
       await expect.element(link).toHaveAttribute("href", `${filePath}#L1`);
 
@@ -76,4 +76,66 @@ describe("ChatMarkdown", () => {
       await screen.unmount();
     }
   });
+
+  it("shows column information inline when present", async () => {
+    const filePath =
+      "/Users/yashsingh/p/sco/claude-code-extract/src/utils/permissions/PermissionRule.ts";
+    const screen = await render(
+      <ChatMarkdown text={`[PermissionRule.ts](file://${filePath}#L1C7)`} cwd="/repo/project" />,
+    );
+
+    try {
+      const link = page.getByRole("link", { name: "PermissionRule.ts · L1:C7" });
+      await expect.element(link).toBeInTheDocument();
+      await expect.element(link).toHaveAttribute("href", `${filePath}#L1C7`);
+
+      await link.click();
+
+      await vi.waitFor(() => {
+        expect(openInPreferredEditorMock).toHaveBeenCalledWith(
+          expect.anything(),
+          `${filePath}:1:7`,
+        );
+      });
+    } finally {
+      await screen.unmount();
+    }
+  });
+
+  it("disambiguates duplicate file basenames inline", async () => {
+    const firstPath = "/Users/yashsingh/p/t3code/apps/web/src/components/chat/MessagesTimeline.tsx";
+    const secondPath = "/Users/yashsingh/p/t3code/apps/web/src/components/MessagesTimeline.tsx";
+    const screen = await render(
+      <ChatMarkdown
+        text={`See [MessagesTimeline.tsx](file://${firstPath}) and [MessagesTimeline.tsx](file://${secondPath}).`}
+        cwd="/repo/project"
+      />,
+    );
+
+    try {
+      await expect
+        .element(page.getByRole("link", { name: "MessagesTimeline.tsx · components/chat" }))
+        .toBeInTheDocument();
+      await expect
+        .element(page.getByRole("link", { name: "MessagesTimeline.tsx · src/components" }))
+        .toBeInTheDocument();
+    } finally {
+      await screen.unmount();
+    }
+  });
+
+  it("keeps normal web links unchanged", async () => {
+    const screen = await render(
+      <ChatMarkdown text="[OpenAI](https://openai.com/docs)" cwd="/repo/project" />,
+    );
+
+    try {
+      const link = page.getByRole("link", { name: "OpenAI" });
+      await expect.element(link).toBeInTheDocument();
+      await expect.element(link).toHaveAttribute("href", "https://openai.com/docs");
+      await expect.element(link).toHaveAttribute("target", "_blank");
+    } finally {
+      await screen.unmount();
+    }
+  });
 });