refactor(codex): integrate effect-codex-app-server and remove legacy manager#65
Merged
Merged
Conversation
Co-authored-by: codex <codex@users.noreply.github.com>
…f42fba0` (pingdotgg#2276) Co-authored-by: Cursor Agent <cursoragent@cursor.com>
…gdotgg#2210) Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Co-authored-by: = <=>
Upstream pingdotgg#1942 dropped this import assuming the corresponding describe block was already gone, but that block-removal commit was never ported to MarCode. MarCode still exports PROVIDER_OPTIONS and still has the describe block, so the import must stay until/unless we also port the block-removal.
Completes the rebrand pass that landed partially in 5ad43ef — the prior commit only covered Codex-adjacent files. This sweeps every user-facing "T3 Code" string, every `t3/provider/Services/...` service tag, Cursor/OpenCode/Claude disabled messages, OpenCode version upgrade copy, OpenCode title templates, SettingsPanels tooltip, and scattered test fixtures (fake paths, tempfile prefixes, bootstrap branch name, T3CODE_CURSOR_ENABLED env var) to MarCode. Kept on purpose: - apps/web/src/uiStateStore.ts `LEGACY_PERSISTED_STATE_KEYS` — these are backward-compat migration keys so T3 Code users keep their UI state when upgrading to MarCode. Removing them drops that path. - apps/web/src/featureGuards.test.ts string literals — they are the forbidden-token patterns the regression guard searches for. - AGENTS.md "pingdotgg/t3code" — legitimate reference to the upstream fork source, not user-facing. Test side-effect: ProviderRegistry.test.ts and providerStatusCache .test.ts now assert the rebranded error strings, matching source.
Reverts the user-facing default chosen in 4c32418 ("set Opus 4.7 default effort to High"). Per request, Extra High is the preferred default. Adapter test updated: with xhigh default, the SDK receives `max` (per the existing xhigh→max mapping in ClaudeAdapter).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
codexAppServerManager.ts(~1632 lines) and its test suite (~1218 lines) which centralized all Codex RPC protocol handling, session management, and approval/user-input trackingeffect-codex-app-serverpackage with Effect-based architecture for cleaner protocol composition and error handlingCodexDeveloperInstructions.tswith collaboration mode configuration (plan/default modes)CODEX_HOMEenvironment variable handlingTesting
be75785504ff152fa6333e380a2d50642f42fba0pathExpansion.test.tsfor tilde expansion behaviorCODEX_BINARY_PATHenvironment variable)