fix: parse returns null for invalid data and allows ignoreOwnership override (#553, #561) (#562)

Author: anatolzak

CHANGELOG.md

@@ -638,4 +638,9 @@ All notable changes to this project will be documented in this file. Breaking ch
 
 ## [3.7.1]
 ### Added
-- [Issue #543](https://github.com/tywalch/electrodb/issues/543); New `client` option for `go()` method allowing dynamic DynamoDB client override at query execution time. This enables use cases like multi-region routing, per-request client selection, and easier testing. Supported for all operation types: entity operations, collection queries, batch operations, and transactions.
+- [Issue #543](https://github.com/tywalch/electrodb/issues/543); New `client` option for `go()` method allowing dynamic DynamoDB client override at query execution time. This enables use cases like multi-region routing, per-request client selection, and easier testing. Supported for all operation types: entity operations, collection queries, batch operations, and transactions.
+
+## [3.7.2]
+### Fixed
+- [Issue #553](https://github.com/tywalch/electrodb/issues/553); Fixed `parse` method returning data instead of `null` for invalid items.
+- [Issue #561](https://github.com/tywalch/electrodb/issues/561); Fixed `parse` method not allowing the `ignoreOwnership` option to be overridden.

package-lock.json

@@ -1,6 +1,6 @@
 {
   "name": "electrodb",
-  "version": "3.7.1",
+  "version": "3.7.2",
   "description": "A library to more easily create and interact with multiple entities and heretical relationships in dynamodb",
   "main": "index.js",
   "scripts": {

package.json

@@ -921,6 +921,8 @@ class Entity {
   is(item, config) {
     return (
       config.ignoreOwnership &&
+      config.attributes &&
+      config.attributes.length > 0 &&
       !this._itemIncludesKeys(item)
     ) || (
       (config.ignoreOwnership || config.hydrate) &&
@@ -1019,8 +1021,8 @@ class Entity {
       return null;
     }
     const config = {
-      ...(options || {}),
       ignoreOwnership: true,
+      ...(options || {}),
     };
     return this.formatResponse(item, TableIndex, config);
   }

src/entity.js

@@ -8920,4 +8920,96 @@ describe("Entity", () => {
       });
     });
   });
+
+  describe("parse", () => {
+    const entity = new Entity({
+      model: {
+        entity: "Item",
+        service: "Playground",
+        version: "1",
+      },
+      attributes: {
+        id: {
+          type: "string",
+          required: true,
+        },
+        name: {
+          type: "string",
+          required: true,
+        },
+        description: {
+          type: "string",
+          required: true,
+        },
+      },
+      indexes: {
+        byId: {
+          pk: {
+            field: "pk",
+            composite: ["id"],
+          },
+          sk: {
+            field: "sk",
+            composite: ["id"],
+          },
+        },
+      },
+    });
+
+    it("should return null when item has no key fields", () => {
+      const result = entity.parse({ Item: { description: "desc" } });
+      expect(result.data).to.be.null;
+    });
+
+    it("should return null when item is empty", () => {
+      const result = entity.parse({ Item: {} });
+      expect(result.data).to.be.null;
+    });
+
+    it("should return null when item has unrelated attributes", () => {
+      const result = entity.parse({ Item: { other: "value" } });
+      expect(result.data).to.be.null;
+    });
+
+    it("should parse a valid item with correct keys", () => {
+      const result = entity.parse({
+        Item: {
+          pk: "$playground#id_123",
+          sk: "$item_1#id_123",
+          id: "123",
+          name: "test",
+          description: "desc",
+        },
+      });
+      expect(result.data).to.deep.equal({ id: "123", name: "test", description: "desc" });
+    });
+
+    it("should return null when ignoreOwnership is overridden to false and item lacks entity identifiers", () => {
+      const result = entity.parse({
+        Item: {
+          pk: "$playground#id_123",
+          sk: "$item_1#id_123",
+          id: "123",
+          name: "test",
+          description: "desc",
+        },
+      }, { ignoreOwnership: false });
+      expect(result.data).to.be.null;
+    });
+
+    it("should parse when ignoreOwnership is false and item has correct entity identifiers", () => {
+      const result = entity.parse({
+        Item: {
+          pk: "$playground#id_123",
+          sk: "$item_1#id_123",
+          id: "123",
+          name: "test",
+          description: "desc",
+          __edb_e__: "Item",
+          __edb_v__: "1",
+        },
+      }, { ignoreOwnership: false });
+      expect(result.data).to.deep.equal({ id: "123", name: "test", description: "desc" });
+    });
+  });
 });