Fix bug where multiple non-ajax forms, with validation errors, breaks conditional logic.#29
Open
mellodave wants to merge 4 commits into
Open
Fix bug where multiple non-ajax forms, with validation errors, breaks conditional logic.#29mellodave wants to merge 4 commits into
mellodave wants to merge 4 commits into
Conversation
…ticular form on the page, as hidden values in the form submission
…ge when a non-ajax submissions resulted in validation errors, which was then breaking conditional logic
|
Thanks for this! Took awhile to realize this was the issue but your solution looks to be working great. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This happens when there are more than one form on the page, and at least one of them is set to submit without ajax. If this submission results in validation errors, then the original code was setting $_POST['gform_random_id'] for all of the forms on the page, not just for the one that was failing. This resulted in, among other things, conditional logic for all but the last form on the page, to break (because window['gf_form_conditional_logic'] was being overwritten by every form).
This fix tries to detect when a $_POST['gform_random_id'] takes place, and only re-use that id for the form that originally had it. All other forms get new random ids.
The only use case that I could find that is still problematic is when there are more than one form of the same type on the page, and one is set to submit via ajax, and the other is not. This doesn't work - all forms of the same type need to use the same submission methods (ajax, or non-ajax). Forms of different types, however, can be set to have different submission methods, without a problem.