`listDetails.parent !== undefined` too strict and doesn't work when `null`

[moll]

Prerequisites

• I verified that this is not a filter list issue. Report any issues with filter lists or broken website functionality in the uAssets issue tracker.
• This is NOT a YouTube, Facebook or Twitch report. These sites MUST be reported by clicking their respective links.
• This is not a support issue or a question. For support, questions, or help, visit /r/uBlockOrigin.
• I performed a cursory search of the issue tracker to avoid opening a duplicate issue.
• The issue is not present after disabling uBO in the browser.
• I checked the documentation to understand that the issue I am reporting is not normal behavior.

I tried to reproduce the issue when...

• uBO is the only extension.
• uBO uses default lists and settings.
• using a new, unmodified browser profile.

Description

Hey,

Thanks for maintaining uBlock Origin! Debugging why the filter list page doesn't render at all, I discovered that it tries to render a listDetails item whose parent is null, thereby throwing on line 249 in 3p-filters.js:
https://github.com/gorhill/uBlock/blob/359cb070eb220186afdc7e29570cb447071831ba/src/js/3p-filters.js#L249

It happens currently with the "AdGuard – Social Widgets" list, but given the defensive coding attempt, I'm guessing uBlock Origin intended to work with items lacking parents. It's just that the strict comparison to undefined doesn't catch the null case and therefore still tries to invoke listDetails.parent.split.

A specific URL where the issue occurs.

http://localhost

Steps to Reproduce

Expected behavior

Actual behavior

uBO version

1.68.0

Browser name and version

Firefox v147.0.1

Operating System and version

Linux

[peppermintsodaa]

Hi, I believe I might know how to fix this issue (with just simply adding a couple more Boolean code), but I'm not sure how I could successfully put up a pull request as I currently do not have the permissions to push my branch. Does the issue have to be assigned?

[gorhill]

There is no issue, it's working as intended.

[peppermintsodaa]

All good, thanks for your prompt response.

[moll]

@gorhill:

There is no issue, it's working as intended.

I'd like to push back a little against this. What is the intended behavior if listDetails.parent is null? Right now it crashes and thereby causes the settings page to fail to render. As I wrote above, I saw the "AdGuard – Social Widgets" list causing the crash as it was trying to render with a null listDetails.parent. I don't know how the "Social Widgets" list's cache got to that state (I certainly haven't messed with it) — maybe it was temporarily published with some parent-relationship field as null — but the fact was, it was broken, and the 3p-filters.js file seems to want to be defensive. Just right now its defensiveness is incomplete.

[gorhill]

You did not provide any steps to reproduce, just that "It happens currently with the "AdGuard – Social Widgets" -- I don't see this happening with any lists.