re-add DataView support, update RecognizedString type (#1274)

Author: BV-WebDev

docs/index.d.ts

@@ -42,15 +42,15 @@ export interface AppDescriptor {
 
 /** Recognized string types, things C++ can read and understand as strings.
  * "String" does not have to mean "text", it can also be "binary".
- *
+ * 
  * Ironically, JavaScript strings are the least performant of all options, to pass or receive to/from C++.
- * This because we expect UTF-8, which is packed in 8-byte chars. JavaScript strings are UTF-16 internally meaning extra copies and reinterpretation are required.
- *
+ * This because we expect UTF-8. JavaScript strings are Latin-1 or UTF-16 internally meaning extra copies and reinterpretation are required.
  * That's why all events pass data by ArrayBuffer and not JavaScript strings, as they allow zero-copy data passing.
- *
  * You can always do Buffer.from(arrayBuffer).toString(), but keeping things binary and as ArrayBuffer is preferred.
+ * 
+ * The ArrayBufferView type includes Node.js Buffer, DataView, and TypedArray (Uint8Array, Uint16Array, ...).
  */
-export type RecognizedString = string | ArrayBuffer | Uint8Array | Int8Array | Uint16Array | Int16Array | Uint32Array | Int32Array | Float32Array | Float64Array;
+export type RecognizedString = string | ArrayBuffer | SharedArrayBuffer | ArrayBufferView;
 
 /** A WebSocket connection that is valid from open to close event.
  * Read more about this in the user manual.

docs/tsconfig.json

@@ -1,5 +1,8 @@
 {
 	"files": [ "index.d.ts" ],
+	"compilerOptions": {
+		"lib": [ "es2017" ]
+	},
 	"typedocOptions": {
 		"name":"uWebSockets.js v20.61.0 documentation",
 		"entryPoints": [ "index.d.ts" ],

src/Utilities.h

@@ -174,7 +174,7 @@ class NativeString {
             allocated = true;
             string->WriteUtf8(isolate, data, length, nullptr, String::WriteOptions::NO_NULL_TERMINATION);
 
-        } else if (value->IsTypedArray()) {
+        } else if (value->IsArrayBufferView()) { /* DataView or TypedArray */
             Local<ArrayBufferView> arrayBufferView = Local<ArrayBufferView>::Cast(value);
             auto contents = arrayBufferView->Buffer()->GetBackingStore();
             length = arrayBufferView->ByteLength();
@@ -196,7 +196,7 @@ class NativeString {
 
     bool isInvalid(const FunctionCallbackInfo<Value> &args) {
         if (invalid) {
-            args.GetReturnValue().Set(args.GetIsolate()->ThrowException(v8::Exception::Error(String::NewFromUtf8(args.GetIsolate(), "Text and data can only be passed by String, ArrayBuffer or TypedArray.", NewStringType::kNormal).ToLocalChecked())));
+            args.GetReturnValue().Set(args.GetIsolate()->ThrowException(v8::Exception::Error(String::NewFromUtf8(args.GetIsolate(), "Text and data can only be passed by String, ArrayBuffer or ArrayBufferView.", NewStringType::kNormal).ToLocalChecked())));
         }
         return invalid;
     }