adoptSocket: add optional ip parameter#1921
Merged
uNetworkingAB merged 1 commit intouNetworking:masterfrom Apr 22, 2026
Merged
Conversation
for the ip to be correctly set in the open handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to uWS.js issue 1257.
Depends on uSockets PR 251.
Update
adoptSocket()to accept an optional IP parameter.Update LocalCluster and
addChildApp()to retrieve the IP on pre_open and pass it toadoptSocket().Allowing the IP to be correctly set in the uSockets open handler for the adopted socket.
If someone accepts external FD, needs the IP on the request and uses the UWS_REMOTE_ADDRESS_USERSPACE cache, they have to pass the IP to adoptSocket().