chore(release): force tag fetch in release-portlet.sh preflight#443
Open
bjagg wants to merge 1 commit into
Open
chore(release): force tag fetch in release-portlet.sh preflight#443bjagg wants to merge 1 commit into
bjagg wants to merge 1 commit into
Conversation
Problem: the tree-state `git fetch upstream <branch> --tags` had no `--force`, so a stale local tag (one re-cut on upstream during an earlier release) could exit non-zero and, under `set -euo pipefail`, silently abort the whole script right after the branch check. Goal: don't let stale local tags abort a release. Changes: - release-portlet.sh: add `--force` to the tree-state tag fetch. Notes: mirrors uPortal PR #3005 (release-uportal.sh). This Maven script does NOT need #3005's push-branch fix — maven-release-plugin already pushes master to upstream via scm.developerConnection. bash -n clean.
ChristianMurphy
approved these changes
Jul 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: the tree-state
git fetch upstream <branch> --tagshad no--force, so a stale local tag (one re-cut on upstream during an earlier release) could exit non-zero and — underset -euo pipefail— silently abort the whole script right after the branch check. (This bit the uPortal release; the portlet scripts share the same line.)Goal: don't let stale local tags abort a release.
Changes (
release-portlet.sh):--forceto the tree-state tag fetch.Notes: mirrors uPortal #3005 (
release-uportal.sh). This Maven script does not need #3005's push-branch fix —maven-release-pluginalready pushes master to upstream viascm.developerConnection.bash -nclean.