Update read_local to handle comma-delimited SCNL inputs and add verbose flag#39
Open
darren-tpk wants to merge 4 commits into
Open
Update read_local to handle comma-delimited SCNL inputs and add verbose flag#39darren-tpk wants to merge 4 commits into
darren-tpk wants to merge 4 commits into
Conversation
Collaborator
Author
|
do we also want to swap out |
to accommodate different miniseed naming patterns (some include a minute field, or have channels with extra dots and letters) and trailing file names (e.g., .mseed)
1. Currently coord_file must contain a dictionary mapping station codes to latitude, longitude and elevation in a tuple. 2. Infrasound arrays typically contain sensors that share the same station code but have different location codes and coordinates. 3. I would argue for the dictionary to use tr.id as keys instead of just the station code, and for the coordinates assignment to not be fatal. 4. Current commit allows for a coord_file=None backdoor. Perhaps coord_file should be an optional argument that defaults to None. Just in case other codes depend on the current position of coord_file as the 2nd input, I am not moving it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
itertools.product. This follows the behavior ofobspy.clients.fdsn.client.get_waveforms().