Model Map.remove as nullable

Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>

Author: codingkiddo

nullaway/src/main/java/com/uber/nullaway/handlers/LibraryModelsHandler.java

@@ -971,6 +971,7 @@ private static class DefaultLibraryModels implements LibraryModels {
             .add(methodRef("java.lang.ref.WeakReference", "get()"))
             .add(methodRef("java.nio.file.Path", "getParent()"))
             .add(methodRef("java.util.Map", "get(java.lang.Object)"))
+            .add(methodRef("java.util.Map", "remove(java.lang.Object)"))
             .add(methodRef("javax.lang.model.element.Element", "getEnclosingElement()"))
             .add(methodRef("javax.lang.model.element.ExecutableElement", "getDefaultValue()"))
             .add(methodRef("javax.lang.model.element.PackageElement", "getEnclosingElement()"))

nullaway/src/test/java/com/uber/nullaway/FrameworkTests.java

@@ -831,6 +831,22 @@ void foo() {
         .doTest();
   }
 
+  @Test
+  public void defaultLibraryModelsMapRemove() {
+    defaultCompilationHelper
+        .addSourceLines(
+            "Test.java",
+            "package com.uber;",
+            "import java.util.Map;",
+            "class Test {",
+            "  void testMapRemove(Map<String, Object> map) {",
+            "    // BUG: Diagnostic contains: dereferenced expression 'map.remove(\"key\")' is @Nullable",
+            "    map.remove(\"key\").toString();",
+            "  }",
+            "}")
+        .doTest();
+  }
+
   @Test
   public void mapGetOrDefault() {
     String[] sourceLines =