feat(lib/store): verify download blob digest when moving to cache#641
Open
thijmv wants to merge 1 commit into
Open
feat(lib/store): verify download blob digest when moving to cache#641thijmv wants to merge 1 commit into
thijmv wants to merge 1 commit into
Conversation
thijmv
force-pushed
the
thijmv/download-digest-verification
branch
from
July 3, 2026 13:35
8153ee8 to
908f36e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds digest verification when downloading a blob through the
CADownloadStore, before moving it to the cache. Previously, only the CRC32 of individual pieces was verified during download. The SHA256 of the assembled blob was never checked before being cached under its trusted digest, meaning a malicious peer could poison the cache with content that does not match the requested digest. This PR closes that gap by validating the SHA256 of a blob before the move.Note that this change trades performance for security, as the digest of every blob must now be computed before moving it to the cache.
Digest validation can be opted out of via a dedicated
SkipHashVerificationflag, but this is not recommended.Fixes #638.