feat(scip-lib): Add symbol visited callback#51
Merged
Conversation
zerunz
approved these changes
Mar 31, 2026
mnoah1
approved these changes
Mar 31, 2026
Collaborator
|
Thanks for your PR, a couple of thoughts I had while reviewing (and I'll be honest the documentLoaded callback was added hastily without much thought):
I'd like #2 addressed primarily (and 3 but I assume there's nothing to do there), and then we can discuss what the callback struct may look like in a separate issue. |
JamyDev
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
What:
Why:
Type of Change
Component(s) Affected
Testing
bazel test //...)Manual Testing Details
Describe how you tested these changes:
Checklist
Screenshots/Logs (if applicable)
N/A
Related Issues
N/A
Additional Notes
This is a breaking interface change; any external implementations of
PartialIndexorRegistrywill need to add the new method. The callback mirrors the existingSetDocumentLoadedCallbackpattern.