Update

Author: yushan8

controller/getchangedtargets.go

@@ -89,8 +89,7 @@ func (c *controller) GetChangedTargets(request *pb.GetChangedTargetsRequest, str
 			cacheKey := common.GetComparedTargetsCachePath(request.GetFirstRevision().GetRemote(), treehash1, treehash2, request.GetRequestOptions())
 			cachedReader, cacheErr := storage.NewChangedTargetsReader(ctx, c.storage, cacheKey)
 			if cacheErr != nil && !storage.IsNotFound(cacheErr) {
-				logger.Error("GetChangedTargets: failed to read from cache", zap.Error(cacheErr))
-				return fmt.Errorf("failed to read from cache: %w", cacheErr)
+				logger.Warn("GetChangedTargets: failed to read from cache, proceeding to compute", zap.Error(cacheErr))
 			} else if cachedReader != nil {
 				// Buffer all responses before sending any. A concurrent goroutine write may have
 				// left a partial blob in storage; buffering lets us detect corruption and fall
@@ -114,25 +113,24 @@ func (c *controller) GetChangedTargets(request *pb.GetChangedTargetsRequest, str
 					cached = append(cached, resp)
 				}
 				if closeErr := cachedReader.Close(); closeErr != nil {
-					logger.Error("GetChangedTargets: failed to close cached reader", zap.Error(closeErr))
-					return fmt.Errorf("close cached reader: %w", closeErr)
+					logger.Warn("GetChangedTargets: failed to close cached reader", zap.Error(closeErr))
 				}
 
 				if readErr != nil {
-					logger.Error("GetChangedTargets: failed to read cached response", zap.Error(readErr))
-					return fmt.Errorf("read cached response: %w", readErr)
-				}
-				cacheReadDuration := time.Since(cacheStart)
-				scope.Counter("changed_targets_cache_hit").Inc(1)
-				scope.Timer("cache_read_duration").Record(cacheReadDuration)
-				if sendErr := sendTrimmedChangedTargets(stream, cached, maxDist, request.GetOutputConfig()); sendErr != nil {
-					logger.Error("GetChangedTargets: failed to send cached response", zap.Error(sendErr))
-					return fmt.Errorf("failed to send cached response: %w", sendErr)
+					logger.Warn("GetChangedTargets: cached result is incomplete, recomputing", zap.Error(readErr))
+				} else {
+					cacheReadDuration := time.Since(cacheStart)
+					scope.Counter("changed_targets_cache_hit").Inc(1)
+					scope.Timer("cache_read_duration").Record(cacheReadDuration)
+					if sendErr := sendTrimmedChangedTargets(stream, cached, maxDist, request.GetOutputConfig()); sendErr != nil {
+						logger.Error("GetChangedTargets: failed to send cached response", zap.Error(sendErr))
+						return fmt.Errorf("failed to send cached response: %w", sendErr)
+					}
+					totalDuration := time.Since(start)
+					scope.Timer("total_duration").Record(totalDuration)
+					scope.Histogram("total_duration.histogram", c.totalDurationBuckets).RecordDuration(totalDuration)
+					return nil
 				}
-				totalDuration := time.Since(start)
-				scope.Timer("total_duration").Record(totalDuration)
-				scope.Histogram("total_duration.histogram", c.totalDurationBuckets).RecordDuration(totalDuration)
-				return nil
 			}
 		}
 	}

orchestrator/native_orchestrator.go

@@ -128,9 +128,9 @@ func (b *nativeOrchestrator) GetTargetGraph(ctx context.Context, param GetTarget
 	}
 	defer func() {
 		if releaseErr := ws.Release(); releaseErr != nil {
-			retErr = errors.Join(retErr, fmt.Errorf("release workspace: %w", releaseErr))
+			logger.Warnw("GetTargetGraph: failed to release workspace", zap.Error(releaseErr))
 			if removeErr := os.RemoveAll(ws.Path()); removeErr != nil {
-				retErr = errors.Join(retErr, fmt.Errorf("remove workspace: %w", removeErr))
+				logger.Warnw("GetTargetGraph: failed to remove workspace", zap.Error(removeErr))
 			}
 		}
 	}()