Runwhile support (limited)#84
Open
SeregaKR wants to merge 12 commits into
Open
Conversation
for more information, see https://pre-commit.ci
Added description of the changes
Add TimeTorque driver
timetorque driver
timetorque driver
for more information, see https://pre-commit.ci
Optimized the code
for more information, see https://pre-commit.ci
Contributor
Author
|
Waiting for a reply from colleagues. But by quick Googling, there are a few common scenarios that I think should be implemented:
I think we should have a parameter for the time limit, comparison (like > or <) and number. The question is should we have separate parameters for each magnetization component or just pass the name.
|
Open
36 tasks
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to separate it into two pull requests as asked. This is the proposed change for RunWhile support.
I personally also don't have much experience with RunWhile - I'll check with some of my colleagues for use cases. For now I suggest introducing the most widely used scenarios and letting the users pass other conditions directly as string.