Fix metamodel path and Needs defaults (eclipse-score#548)

* fix:  external metamodel.yaml path

Sphinx-build changes working dir to where conf.py is.
Bazel provides a path relative to the workspace.
By making the path absolute it works out.

* fix: clear Sphinx-Needs defaults

Author: a-zw

src/extensions/score_metamodel/__init__.py

@@ -291,6 +291,26 @@ def postprocess_need_links(needs_types_list: list[ScoreNeedType]):
                 )
 
 
+def _clear_needs_defaults(app: Sphinx):
+    """Clear default need types, links and fields provided by sphinx-needs.
+
+    This ensures that only the need types defined in our metamodel are used,
+    and prevents issues where the defaults get merged with our types and cause
+    unexpected behavior.
+    """
+    default_directives = {"need", "req", "spec", "impl", "test"}
+    existing_directives = {nt["directive"] for nt in app.config.needs_types}
+    if existing_directives == default_directives:
+        app.config.needs_types.clear()
+        logger.info("Cleared default Sphinx-Needs types: %s", default_directives)
+    else:
+        logger.info(
+            f"Expected default need types {default_directives} not found. "
+            "Not clearing needs_types to avoid accidentally removing custom types. "
+            f"Existing directives: {existing_directives}"
+        )
+
+
 def setup(app: Sphinx) -> dict[str, str | bool]:
     app.add_config_value("external_needs_source", "", rebuild="env")
     app.add_config_value("score_metamodel_yaml", "", rebuild="env")
@@ -303,6 +323,7 @@ def setup(app: Sphinx) -> dict[str, str | bool]:
     metamodel = load_metamodel_data(override_path)
 
     # Extend sphinx-needs config rather than overwriting
+    _clear_needs_defaults(app)
     app.config.needs_types += metamodel.needs_types
     app.config.needs_links.update(metamodel.needs_links)
     app.config.needs_fields.update(metamodel.needs_fields)

src/incremental.py

@@ -86,6 +86,10 @@ def get_env(name: str) -> str:
 
     metamodel_yaml = os.environ.get("SCORE_METAMODEL_YAML", "")
     if metamodel_yaml:
+        # Normalize to absolute path so it resolves correctly after Sphinx changes cwd
+        if not os.path.isabs(metamodel_yaml):
+            metamodel_yaml = workspace + metamodel_yaml
+        metamodel_yaml = os.path.abspath(metamodel_yaml)
         base_arguments.append(f"--define=score_metamodel_yaml={metamodel_yaml}")
 
     # configure sphinx build with GitHub user and repo from CLI