This repository was archived by the owner on Dec 12, 2022. It is now read-only.
ubports-qa upgrades only the packages related to the PR/MR repo#30
Open
Fuseteam wants to merge 13 commits into
Open
ubports-qa upgrades only the packages related to the PR/MR repo#30Fuseteam wants to merge 13 commits into
Fuseteam wants to merge 13 commits into
Conversation
mardy
reviewed
Mar 7, 2022
Member
mardy
left a comment
There was a problem hiding this comment.
Added a few remarks, but I also would prefer if this were implemented in python (I'm also fine if the whole script gets rewritten in bash, but this hybrid is not very nice IMHO) :-)
Author
i don't mind reimplementing it in python fwiw, this was just the easiest way to get something working, as i don't know as much python actually, after submitting this PR i attempted to reimplement pkgremove in python but appearently python's os.check_output quotes the list of packages breaking apt |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
appearently you can upgrade a specific package by apt installing it
this assumes the package name is the same as the repository name, we may need a more robust way to read the correct package name