Skip to content

Change default icon size to 20 so they aren't defacto invisible#552

Open
ahydronous wants to merge 1 commit into
ubuntu:masterfrom
ahydronous:patch-1
Open

Change default icon size to 20 so they aren't defacto invisible#552
ahydronous wants to merge 1 commit into
ubuntu:masterfrom
ahydronous:patch-1

Conversation

@ahydronous
Copy link
Copy Markdown

@ahydronous ahydronous commented Oct 10, 2024

Some users their icons are "invisible" because the default size is set to 0. I chose size 20 because it makes most icons approximately the same size as the built-in top bar icons.

See: #382

Some users their icons are "invisible" because the default size is set to 0.
I chose size 20 because it makes most icons approximately the same size as the built-in top bar icons.

See: ubuntu#382)
@DanHolli
Copy link
Copy Markdown

size of zero is supposed to be an auto size as it functions in Ubuntu, it may be better to submit an issue and figure why yours isn't auto sizing

@3v1n0
Copy link
Copy Markdown
Collaborator

3v1n0 commented May 6, 2025

In theory the code at:

if (sizeValue > 0) {
if (!this._defaultIconSize)
this._defaultIconSize = this._iconSize;
this._iconSize = sizeValue;
} else if (this._defaultIconSize) {
this._iconSize = this._defaultIconSize;
delete this._defaultIconSize;
}

Should prevent this to happen, no?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants