Skip to content

Bug with clock and node emit the same reference#468

Closed
da-steve101 wants to merge 5 commits into
ucb-bar:masterfrom
da-steve101:clockFix
Closed

Bug with clock and node emit the same reference#468
da-steve101 wants to merge 5 commits into
ucb-bar:masterfrom
da-steve101:clockFix

Conversation

@da-steve101
Copy link
Copy Markdown
Contributor

If a clock is created without a reference val, it is given a name with emit ref which may give it the same name as another node and hence result in invalid verilog

Stephen Tridgell added 5 commits July 27, 2015 18:16
not created in with a val. Fixed testsuite forcing this behaviour
Conflicts:
	src/main/scala/Verilog.scala
fix multiple reset issue by ensuring unique def and correct clock names for unnamed clock
@da-steve101
Copy link
Copy Markdown
Contributor Author

I think perhaps i will rework this.
Emitting multiple declarations is a problem for earlier.
Instead i will put in an assertion and say something like "Internal error: invalid cpp code detected"

@da-steve101
Copy link
Copy Markdown
Contributor Author

Closing in favour of cleaner pull request #486 and #487

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant