chore(quality): remove code redundancies across solution

- Bulk-applied via `jb cleanupcode --profile=RemoveRedundancies`
  then `dotnet format`. Removes redundant argument default values,
  redundant member initializers, redundant `else` after `return`,
  redundant anonymous-type property names, and other rewrites in
  the ReSharper "Remove code redundancies" category — all
  compiler-equivalent, no behavior change.
- Updates `Viper.sln.DotSettings`: the umbrella
  `<CSRemoveCodeRedundancies>` flag alone is a no-op. ReSharper
  also requires the (sparsely-documented) sibling
  `<RemoveCodeRedundancies>` flag plus per-rule sub-flags
  (`<CSRemoveRedundantArgumentDefaultValues>`,
  `<CSRemoveRedundantInitializers>`) to actually trigger the
  rewrites.
- Fixes a minor follow-up: `CliniciansController.cs:569` was
  changed to `clinicians.Count` (List property) from
  `clinicians.Count()` (LINQ). The IEnumerable to List
  materialisation in `9823a4c9` made `clinicians` a List, which
  Sonar S2971 then flagged as preferring the property. No new
  lint rule violations introduced by this commit.

Author: rlorenzo

Viper.sln.DotSettings

@@ -1,5 +1,5 @@
 <wpf:ResourceDictionary xml:space="preserve" xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml" xmlns:s="clr-namespace:System;assembly=mscorlib" xmlns:ss="urn:shemas-jetbrains-com:settings-storage-xaml" xmlns:wpf="http://schemas.microsoft.com/winfx/2006/xaml/presentation">
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=OptimizeUsings/@EntryIndexedValue">&lt;Profile name="OptimizeUsings"&gt;&lt;CSOptimizeUsings&gt;&lt;OptimizeUsings&gt;True&lt;/OptimizeUsings&gt;&lt;EmbraceInRegion&gt;False&lt;/EmbraceInRegion&gt;&lt;RegionName&gt;&lt;/RegionName&gt;&lt;/CSOptimizeUsings&gt;&lt;/Profile&gt;</s:String>
 	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=ShortenReferences/@EntryIndexedValue">&lt;Profile name="ShortenReferences"&gt;&lt;CSShortenReferences&gt;True&lt;/CSShortenReferences&gt;&lt;/Profile&gt;</s:String>
-	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=RemoveRedundancies/@EntryIndexedValue">&lt;Profile name="RemoveRedundancies"&gt;&lt;CSRemoveCodeRedundancies&gt;True&lt;/CSRemoveCodeRedundancies&gt;&lt;/Profile&gt;</s:String>
+	<s:String x:Key="/Default/CodeStyle/CodeCleanup/Profiles/=RemoveRedundancies/@EntryIndexedValue">&lt;Profile name="RemoveRedundancies"&gt;&lt;CSRemoveCodeRedundancies&gt;True&lt;/CSRemoveCodeRedundancies&gt;&lt;RemoveCodeRedundancies&gt;True&lt;/RemoveCodeRedundancies&gt;&lt;CSRemoveRedundantArgumentDefaultValues&gt;True&lt;/CSRemoveRedundantArgumentDefaultValues&gt;&lt;CSRemoveRedundantInitializers&gt;True&lt;/CSRemoveRedundantInitializers&gt;&lt;/Profile&gt;</s:String>
 </wpf:ResourceDictionary>

test/CTS/AssessmentControllerTest.cs

@@ -164,7 +164,7 @@ public async Task CreateStudentEpaCheck()
             context.Database.Returns(facadeSub);
 
             var actrlAsFac = GetAssessmentController(SetupUsers.UserType.Faculty);
-            var newEpa = new CreateUpdateStudentEpa()
+            var newEpa = new CreateUpdateStudentEpa
             {
                 EncounterDate = DateTime.Now,
                 Comment = "A comment",
@@ -204,7 +204,7 @@ public async Task UpdateStudentEpaCheck()
             var encId1 = SetupAssessments.Encounters.First(e => e.EnteredBy == SetupUsers.facultyUser.AaudUserId).EncounterId;
             var encId2 = SetupAssessments.Encounters.First(e => e.EnteredBy != SetupUsers.facultyUser.AaudUserId).EncounterId;
 
-            var epa1 = new CreateUpdateStudentEpa()
+            var epa1 = new CreateUpdateStudentEpa
             {
                 EncounterId = encId1,
                 EncounterDate = DateTime.Now,
@@ -214,7 +214,7 @@ public async Task UpdateStudentEpaCheck()
                 ServiceId = 0,
                 StudentId = SetupUsers.studentUser1.AaudUserId,
             };
-            var epa2 = new CreateUpdateStudentEpa()
+            var epa2 = new CreateUpdateStudentEpa
             {
                 EncounterId = encId2,
                 EncounterDate = DateTime.Now,
@@ -224,7 +224,7 @@ public async Task UpdateStudentEpaCheck()
                 ServiceId = 0,
                 StudentId = SetupUsers.studentUser1.AaudUserId,
             };
-            var epa3 = new CreateUpdateStudentEpa()
+            var epa3 = new CreateUpdateStudentEpa
             {
                 EncounterId = 99999,
                 EncounterDate = DateTime.Now,

test/CTS/CompetencyBundleAssociationControllerTest.cs

@@ -112,7 +112,7 @@ public CompetencyBundleAssociationControllerTest()
         public async Task GetCompetencyBundleAssociations_NoFilters_ReturnsOnlyUnbundledCompetencies()
         {
             // Act
-            var result = await _controller.GetCompetencyBundleAssociations(null, null, null);
+            var result = await _controller.GetCompetencyBundleAssociations();
 
             // Assert
             var okResult = Assert.IsType<ActionResult<List<CompetencyBundleAssociationDto>>>(result);

test/CTS/SetupAssessments.cs

@@ -9,46 +9,46 @@ namespace Viper.test.CTS
 {
     internal static class SetupAssessments
     {
-        public static readonly List<Encounter> Encounters = new List<Encounter>()
+        public static readonly List<Encounter> Encounters = new List<Encounter>
         {
-            new Encounter()
+            new Encounter
             {
                 EncounterId = 1,
                 EnteredBy = SetupUsers.facultyUser.AaudUserId,
                 EnteredOn = DateTime.Now,
                 StudentUserId = SetupUsers.studentUser1.AaudUserId,
                 EncounterType = (int)EncounterCreationService.EncounterType.Epa,
-                Student = new Person()
+                Student = new Person
                 {
                     FullName = SetupUsers.studentUser1.DisplayLastName + ", " + SetupUsers.studentUser1.DisplayFirstName,
                     MailId = "",
                 },
                 EnteredByPerson = SetupPeople.GetPeople().Where(p => p.PersonId == SetupUsers.facultyUser.AaudUserId).FirstOrDefault(),
                 ServiceId = 1,
             },
-            new Encounter()
+            new Encounter
             {
                 EncounterId = 2,
                 EnteredBy = SetupUsers.facultyUser.AaudUserId,
                 EnteredOn = DateTime.Now,
                 StudentUserId = SetupUsers.studentUser1.AaudUserId,
                 EncounterType = (int)EncounterCreationService.EncounterType.Epa,
-                Student = new Person()
+                Student = new Person
                 {
                     FullName = SetupUsers.studentUser1.DisplayLastName + ", " + SetupUsers.studentUser1.DisplayFirstName,
                     MailId = "",
                 },
                 EnteredByPerson = SetupPeople.GetPeople().Where(p => p.PersonId == SetupUsers.facultyUser.AaudUserId).FirstOrDefault(),
                 ServiceId = 2,
             },
-            new Encounter()
+            new Encounter
             {
                 EncounterId = 3,
                 EnteredBy = SetupUsers.otherFacultyUser.AaudUserId,
                 EnteredOn = DateTime.Now,
                 StudentUserId = SetupUsers.studentUser2.AaudUserId,
                 EncounterType = (int)EncounterCreationService.EncounterType.Epa,
-                Student = new Person()
+                Student = new Person
                 {
                     FullName = SetupUsers.studentUser2.DisplayLastName + ", " + SetupUsers.studentUser2.DisplayFirstName,
                     MailId = "",
@@ -73,7 +73,7 @@ public static void SetupEncountersTable(VIPERContext context)
                 .Do(callInfo =>
                  {
                      var e = callInfo.Arg<Encounter>();
-                     e.Student = new Person()
+                     e.Student = new Person
                      {
                          PersonId = e.StudentUserId,
                      };

test/ClinicalScheduler/EmailNotificationTest.cs

@@ -168,7 +168,7 @@ public async Task RemoveInstructorScheduleAsync_PrimaryEvaluator_SendsEmailNotif
 
             // Create primary evaluator and another instructor (so removal is allowed)
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(mothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();
@@ -249,7 +249,7 @@ await _context.Persons.AddAsync(new Person
 
             await _context.SaveChangesAsync();
 
-            var schedule = TestDataBuilder.CreateInstructorSchedule("test123", rotationId, weekId, false); // Not primary
+            var schedule = TestDataBuilder.CreateInstructorSchedule("test123", rotationId, weekId); // Not primary
             await _context.InstructorSchedules.AddAsync(schedule);
             await _context.SaveChangesAsync();
 
@@ -323,12 +323,12 @@ public async Task RemoveInstructorScheduleAsync_EmailServiceFails_StillCompletes
             var weekId = 10; // Use unique week ID to avoid conflict
 
             await AddTestPersonAsync(mothraId, "John", "Doe");
-            await AddTestWeekGradYearAsync(weekId, 2025);
+            await AddTestWeekGradYearAsync(weekId);
             await AddTestRotationAsync(rotationId);
             await _context.SaveChangesAsync();
 
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(mothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();
@@ -429,7 +429,7 @@ await _context.Persons.AddAsync(new Person
             await _context.SaveChangesAsync();
 
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(mothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();
@@ -506,7 +506,7 @@ public async Task RemoveInstructorScheduleAsync_PrimaryEvaluatorWithMissingWeekD
             await _context.SaveChangesAsync();
 
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(mothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();
@@ -575,12 +575,12 @@ public async Task RemoveInstructorScheduleAsync_MultipleEmailRecipients_SendsToA
                 _mockEmailTemplateRenderer);
 
             await AddTestPersonAsync(mothraId, "John", "Doe");
-            await AddTestWeekGradYearAsync(weekId, 2025);
+            await AddTestWeekGradYearAsync(weekId);
             await AddTestRotationAsync(rotationId, "Oncology", "ONC");
             await _context.SaveChangesAsync();
 
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(mothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other456", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();
@@ -667,7 +667,7 @@ await _context.Persons.AddAsync(new Person
 
             // Create existing primary evaluator and new instructor
             var oldPrimarySchedule = TestDataBuilder.CreateInstructorSchedule(oldPrimaryMothraId, rotationId, weekId, true);
-            var newInstructorSchedule = TestDataBuilder.CreateInstructorSchedule(newPrimaryMothraId, rotationId, weekId, false);
+            var newInstructorSchedule = TestDataBuilder.CreateInstructorSchedule(newPrimaryMothraId, rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(oldPrimarySchedule, newInstructorSchedule);
             await _context.SaveChangesAsync();
@@ -803,7 +803,7 @@ await _context.Persons.AddAsync(new Person
 
             // Create primary evaluator and another instructor (so unsetting is allowed)
             var primarySchedule = TestDataBuilder.CreateInstructorSchedule(primaryMothraId, rotationId, weekId, true);
-            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other789", rotationId, weekId, false);
+            var otherSchedule = TestDataBuilder.CreateInstructorSchedule("other789", rotationId, weekId);
 
             await _context.InstructorSchedules.AddRangeAsync(primarySchedule, otherSchedule);
             await _context.SaveChangesAsync();

test/ClinicalScheduler/InstructorScheduleControllerTest.cs

@@ -54,7 +54,7 @@ public InstructorScheduleControllerTest()
             );
 
             // Set up HTTP context for the controller
-            _controller.ControllerContext = new ControllerContext()
+            _controller.ControllerContext = new ControllerContext
             {
                 HttpContext = new DefaultHttpContext()
             };

test/ClinicalScheduler/Integration/ServiceLayerIntegrationTest.cs

@@ -464,9 +464,9 @@ public async Task ServiceResponses_UseProperDTOStructure()
             // Create a simple service response structure for testing
             var serviceResponse = new
             {
-                ServiceId = service.ServiceId,
-                ServiceName = service.ServiceName,
-                ShortName = service.ShortName,
+                service.ServiceId,
+                service.ServiceName,
+                service.ShortName,
                 Rotations = new List<RotationDto> { rotation1Dto, rotation2Dto }
             };
 

test/ClinicalScheduler/RotationsControllerTest.cs

@@ -203,10 +203,8 @@ private static IEnumerable<RotationDto> ExtractRotationsFromResult(ActionResult<
                 var okResult = Assert.IsType<OkObjectResult>(result.Result);
                 return Assert.IsAssignableFrom<IEnumerable<RotationDto>>(okResult.Value);
             }
-            else
-            {
-                return Assert.IsAssignableFrom<IEnumerable<RotationDto>>(result.Value);
-            }
+
+            return Assert.IsAssignableFrom<IEnumerable<RotationDto>>(result.Value);
         }
 
         [Fact]

test/ClinicalScheduler/ScheduleAuditServiceTest.cs

@@ -13,7 +13,7 @@ public class ScheduleAuditServiceTest : IDisposable
         private readonly ILogger<ScheduleAuditService> _mockLogger;
         private readonly ScheduleAuditService _service;
         private readonly ClinicalSchedulerContext _context;
-        private bool _disposed = false;
+        private bool _disposed;
 
         public ScheduleAuditServiceTest()
         {