Skip to content

Commit 1814f59

Browse files
committed
VPR-54 chore(scheduler): clean up audit findings on controller tests
Drop a private-field-can-be-local on the unused logger reference and remove redundant default ct arguments on two DidNotReceiveWithAnyArgs checks.
1 parent f187088 commit 1814f59

1 file changed

Lines changed: 4 additions & 5 deletions

File tree

test/Scheduler/JobsControllerTests.cs

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -14,15 +14,14 @@ public sealed class JobsControllerTests
1414
{
1515
private readonly ISchedulerJobsService _service;
1616
private readonly IUserHelper _userHelper;
17-
private readonly ILogger<JobsController> _logger;
1817
private readonly JobsController _sut;
1918

2019
public JobsControllerTests()
2120
{
2221
_service = Substitute.For<ISchedulerJobsService>();
2322
_userHelper = Substitute.For<IUserHelper>();
24-
_logger = Substitute.For<ILogger<JobsController>>();
25-
_sut = new JobsController(_service, _userHelper, _logger);
23+
var logger = Substitute.For<ILogger<JobsController>>();
24+
_sut = new JobsController(_service, _userHelper, logger);
2625
}
2726

2827
// ──────────── ListJobs ────────────
@@ -142,7 +141,7 @@ public async Task PauseJob_Returns400OnInvalidBase64RowVersion()
142141
CancellationToken.None);
143142

144143
Assert.IsType<BadRequestObjectResult>(result.Result);
145-
await _service.DidNotReceiveWithAnyArgs().PauseJobAsync(default!, default!, default, default);
144+
await _service.DidNotReceiveWithAnyArgs().PauseJobAsync(default!, default!, default);
146145
}
147146

148147
[Fact]
@@ -184,7 +183,7 @@ public async Task ResumeJob_Returns400WhenRowVersionMissing()
184183
var result = await _sut.ResumeJob("raps:role-refresh", new JobsController.ResumeRequest(), CancellationToken.None);
185184

186185
Assert.IsType<BadRequestObjectResult>(result.Result);
187-
await _service.DidNotReceiveWithAnyArgs().ResumeJobAsync(default!, default!, default);
186+
await _service.DidNotReceiveWithAnyArgs().ResumeJobAsync(default!, default!);
188187
}
189188

190189
[Fact]

0 commit comments

Comments
 (0)