Commit a350ca9
committed
fix(quality): close remaining CodeQL findings on touched files
Aligns the lines already modified in this branch with the closure
work done on codeql/3-correctness so the two branches do not
conflict on merge.
- CMSFile.cs: seal the class to close cs/virtual-call-in-constructor
(no inheritor in C#, no mocking, no UseLazyLoadingProxies).
- CompetencyController.UpdateComptency: drop the now-dead
`CompetencyId <= 0` check. The preceding FindAsync already returns
NotFound when the row is missing; an existing row's identity
column is always a positive int.
- Program.cs SetAwsCredentials: trim the RegionEndpoint value, look
it up with BindingFlags.IgnoreCase, and fall back to USWest1 when
the name is non-empty but does not match any known region. The
previous ternary could leave profile.Region as null on unknown
region names.1 parent 918ce04 commit a350ca9
3 files changed
Lines changed: 13 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2 | 2 | | |
3 | 3 | | |
4 | 4 | | |
5 | | - | |
| 5 | + | |
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
136 | 136 | | |
137 | 137 | | |
138 | 138 | | |
139 | | - | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | 139 | | |
144 | 140 | | |
145 | 141 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
| 2 | + | |
2 | 3 | | |
3 | 4 | | |
4 | 5 | | |
| |||
561 | 562 | | |
562 | 563 | | |
563 | 564 | | |
564 | | - | |
565 | | - | |
566 | | - | |
567 | | - | |
| 565 | + | |
| 566 | + | |
| 567 | + | |
| 568 | + | |
| 569 | + | |
| 570 | + | |
| 571 | + | |
| 572 | + | |
| 573 | + | |
| 574 | + | |
| 575 | + | |
568 | 576 | | |
569 | 577 | | |
570 | 578 | | |
| |||
0 commit comments