Skip to content

Commit b0ed219

Browse files
committed
refactor: remove dead code surfaced by fallow (Phase 1)
- Delete 13 unused files: Vite-starter icon components, an orphan footer layout, two abandoned CTS pages, a refactor- leftover percent-edit dialog, two unused photo-gallery variants, and CSS assets with zero imports. - Drop @quasar/extras and @pinia/testing from package.json after verifying zero usages. Future SVG-icon migration is tracked separately in PLAN-svg.md. - Remove unused exports (and the now-dead local declarations that supported them) from colors.ts, DateFunctions.ts, QuasarConfig.ts, photo-gallery-service.ts, use-percentage- form.ts, error-transformer.ts, permission-messages.ts, and schedule-config.ts. colors.ts in particular collapses from 256 lines to 31 after the dead palette plumbing is removed. - Fallow's `percentRule` and SCHEDULE_LABELS/SCHEDULE_MESSAGES findings are false positives (direct imports and dynamic imports fallow missed) — kept as-is.
1 parent 2580a27 commit b0ed219

21 files changed

Lines changed: 14 additions & 1183 deletions

File tree

VueApp/src/CAHFS/assets/cahfs.css

Whitespace-only changes.

VueApp/src/CMS/assets/cms.css

Whitespace-only changes.

VueApp/src/CTS/pages/CourseList.vue

Lines changed: 0 additions & 4 deletions
This file was deleted.

VueApp/src/CTS/pages/MyAssessmentCharts.vue

Lines changed: 0 additions & 154 deletions
This file was deleted.

VueApp/src/ClinicalScheduler/constants/permission-messages.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -28,10 +28,4 @@ const SCHEDULE_OPERATION_ERRORS = {
2828
NO_PERMISSION_MODIFY_PRIMARY_EVALUATOR: "You do not have permission to modify primary evaluator status.",
2929
} as const
3030

31-
// All permission-related messages
32-
const PERMISSION_MESSAGES = {
33-
...ACCESS_DENIED_MESSAGES,
34-
...SCHEDULE_OPERATION_ERRORS,
35-
} as const
36-
37-
export { ACCESS_DENIED_MESSAGES, ACCESS_DENIED_SUBTITLES, SCHEDULE_OPERATION_ERRORS, PERMISSION_MESSAGES }
31+
export { ACCESS_DENIED_MESSAGES, ACCESS_DENIED_SUBTITLES, SCHEDULE_OPERATION_ERRORS }

VueApp/src/ClinicalScheduler/constants/schedule-config.ts

Lines changed: 1 addition & 35 deletions
Original file line numberDiff line numberDiff line change
@@ -61,38 +61,4 @@ const SCHEDULE_LABELS = {
6161
},
6262
} as const
6363

64-
const SCHEDULE_VIEW_CONFIG = {
65-
// Common view props
66-
DEFAULT_PROPS: {
67-
showLegend: true,
68-
showPrimaryToggle: true,
69-
labelSpacing: "xs" as const,
70-
selectorSpacing: "none" as const,
71-
},
72-
73-
// Rotation view specific
74-
ROTATION_VIEW: {
75-
showWarningInLegend: true,
76-
showWarningIcon: true,
77-
requiresPrimaryForWeek: true,
78-
labelSpacing: "md" as const,
79-
selectorSpacing: "lg" as const,
80-
},
81-
82-
// Clinician view specific
83-
CLINICIAN_VIEW: {
84-
showWarningInLegend: false,
85-
showWarningIcon: false,
86-
requiresPrimaryForWeek: false,
87-
},
88-
} as const
89-
90-
// Type helpers for the constants
91-
type ScheduleMessageKey = keyof typeof SCHEDULE_MESSAGES
92-
type ScheduleLabelKey = keyof typeof SCHEDULE_LABELS
93-
type ViewConfigKey = keyof typeof SCHEDULE_VIEW_CONFIG
94-
95-
// Consolidated exports - types and constants at end of file
96-
export { SCHEDULE_MESSAGES, SCHEDULE_LABELS, SCHEDULE_VIEW_CONFIG }
97-
98-
export type { ScheduleMessageKey, ScheduleLabelKey, ViewConfigKey }
64+
export { SCHEDULE_MESSAGES, SCHEDULE_LABELS }

VueApp/src/ClinicalScheduler/services/error-transformer.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -286,4 +286,4 @@ function getScheduleErrorMessage(error: unknown, operation: "add" | "remove" | "
286286
}
287287

288288
// Export all functions together at the end
289-
export { transformError, getErrorMessage, isErrorKind, getScheduleErrorMessage }
289+
export { transformError, isErrorKind, getScheduleErrorMessage }

0 commit comments

Comments
 (0)