chore(quality): remove dead null-checks flagged by CA1508

- Drop dead `?.` and `!= null` guards in 10 files where the analyzer
  proves the value is non-null (DI-injected helpers, catch
  parameters, values guaranteed by preceding null-checks).
- ViteProxyHelpers.cs: suppress CA1508 with `#pragma warning disable`
  on the inner check of a double-checked locking pattern. The outer
  guard may have raced; CA1508's dataflow analysis doesn't model
  thread interleaving, so this is a known false positive.

Author: rlorenzo

test/CTS/AssessmentControllerTest.cs

@@ -258,7 +258,7 @@ private static bool IsForbidResult<T>(ActionResult<T> a)
                 var forbidResult = a.Result as ForbidResult;
                 if (result != null)
                 {
-                    Assert.Equal((int)HttpStatusCode.Forbidden, result?.StatusCode);
+                    Assert.Equal((int)HttpStatusCode.Forbidden, result.StatusCode);
                 }
                 Assert.True(result != null || forbidResult != null);
 

web/Areas/CTS/Controllers/AssessmentController.cs

@@ -296,7 +296,7 @@ public async Task<ActionResult<CreateUpdateStudentEpa>> CreateStudentEpa(CreateU
                     .Include(p => p.StudentInfo)
                     .Where(p => p.PersonId == epaData.StudentId)
                     .FirstOrDefaultAsync();
-            if (student == null || student?.StudentInfo?.ClassLevel == null)
+            if (student == null || student.StudentInfo?.ClassLevel == null)
             {
                 return BadRequest("Student not found");
             }

web/Areas/CTS/Controllers/CompetencyController.cs

@@ -136,7 +136,7 @@ public async Task<ActionResult<CompetencyDto>> UpdateComptency(int competencyId,
                 return NotFound();
             }
 
-            if (competency.CompetencyId == null || competency.CompetencyId <= 0)
+            if (competency.CompetencyId <= 0)
             {
                 return BadRequest("CompetencyId is required.");
             }

web/Areas/CTS/Controllers/CourseController.cs

@@ -490,7 +490,7 @@ private async Task<List<int>> GetCourseIdsForUserForTerm(string termCode)
                     .ToListAsync();
             }
 
-            return context.GetMyCourses(termCode, Int32.Parse(userHelper?.GetCurrentUser()?.Pidm ?? "0"))
+            return context.GetMyCourses(termCode, Int32.Parse(userHelper.GetCurrentUser()?.Pidm ?? "0"))
                 .Select(c => c.CourseId)
                 .ToList();
         }

web/Areas/CTS/Models/StudentEpaAssessment.cs

@@ -29,7 +29,7 @@ public StudentEpaAssessment(Encounter encounter) : base(encounter, encounter.Lev
             if (encounter.Service != null)
             {
                 ServiceId = encounter.ServiceId;
-                ServiceName = encounter.Service?.ServiceName;
+                ServiceName = encounter.Service.ServiceName;
             }
         }
     }

web/Areas/Effort/Services/EvaluationReportService.cs

@@ -283,8 +283,8 @@ AND quant_mean > 0
         await using var command = new SqlCommand(sql, connection);
         command.Parameters.AddWithValue("@TermCode", termCode);
         command.Parameters.AddWithValue("@Department", (object?)department ?? DBNull.Value);
-        command.Parameters.AddWithValue("@PersonId", (object?)personId ?? DBNull.Value);
-        command.Parameters.AddWithValue("@Role", (object?)ParseRoleFilter(role) ?? DBNull.Value);
+        command.Parameters.AddWithValue("@PersonId", personId);
+        command.Parameters.AddWithValue("@Role", ParseRoleFilter(role));
 
         await using var reader = await command.ExecuteReaderAsync(ct);
         while (await reader.ReadAsync(ct))

web/Areas/Effort/Services/MeritReportService.cs

@@ -271,7 +271,7 @@ private async Task<List<MeritDetailRow>> ExecuteMeritReportSpAsync(
 
         await using var command = new SqlCommand("[effort].[sp_merit_report]", connection);
         command.CommandType = CommandType.StoredProcedure;
-        command.Parameters.AddWithValue("@PersonId", (object?)personId ?? DBNull.Value);
+        command.Parameters.AddWithValue("@PersonId", personId);
         command.Parameters.AddWithValue("@StartTermCode", startTermCode);
         command.Parameters.AddWithValue("@EndTermCode", endTermCode);
         command.Parameters.AddWithValue("@Department", (object?)department ?? DBNull.Value);

web/Areas/RAPS/Services/VMACSExport.cs

@@ -136,10 +136,10 @@ public async Task<List<string>> ExportToVMACS(string instance, string? server =
                     catch (Exception ex)
                     {
                         HttpHelper.Logger.Log(LogLevel.Warn, ex);
-                        RecordMessage(messages, "Error: " + ex.Message + " " + ex?.StackTrace);
-                        if (ex?.InnerException != null)
+                        RecordMessage(messages, "Error: " + ex.Message + " " + ex.StackTrace);
+                        if (ex.InnerException != null)
                         {
-                            RecordMessage(messages, "Error: " + ex.InnerException.Message + " " + ex.InnerException?.StackTrace);
+                            RecordMessage(messages, "Error: " + ex.InnerException.Message + " " + ex.InnerException.StackTrace);
                         }
                     }
                 }

web/Controllers/HomeController.cs

@@ -148,7 +148,7 @@ public IActionResult EmulateUser(string loginId)
 
                 if (protector != null && emulatedUser.LoginId != null)
                 {
-                    string? encryptedEmulatedLoginId = protector?.Protect(emulatedUser.LoginId);
+                    string? encryptedEmulatedLoginId = protector.Protect(emulatedUser.LoginId);
 
                     // set emulating cached item to expire after 30 minutes of inactivity
                     HttpHelper.Cache?.Set(ClaimsTransformer.EmulationCacheNamePrefix + trueLoginId, encryptedEmulatedLoginId, (new MemoryCacheEntryOptions().SetSlidingExpiration(TimeSpan.FromMinutes(30))));

web/Views/Shared/Components/SessionTimeout/SessionTimeout.cs

@@ -13,7 +13,7 @@ public SessionTimeout()
         public async Task<IViewComponentResult> InvokeAsync()
         {
             UserHelper userHelper = new UserHelper();
-            string? loginId = userHelper?.GetCurrentUser()?.LoginId;
+            string? loginId = userHelper.GetCurrentUser()?.LoginId;
             bool onDev = HttpHelper.Environment?.EnvironmentName == "Development";
             ViewData["sessionRefreshUrl"] = (onDev ? "http://localhost/" : ("https://" + HttpHelper.HttpContext?.Request.Host.Value + "/"))
                 + "/public/timeout/seconds_until_timeout_v2.cfm?id="