Skip to content

Commit cd25404

Browse files
committed
VPR-104 fix(a11y): ManageDomains labels, ManageCompetencies empty state
- Add label props to ManageDomains q-inputs for screen reader accessibility (axe: label violation, WCAG 4.1.2) - Show "No competencies found" text instead of empty q-tree to avoid aria-required-children and grey contrast failures on empty state
1 parent 5e31dfd commit cd25404

2 files changed

Lines changed: 17 additions & 17 deletions

File tree

VueApp/src/CTS/pages/ManageCompetencies.vue

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -284,12 +284,19 @@ load()
284284
></q-btn>
285285
</span>
286286
</h3>
287+
<div
288+
v-if="loaded && treeNodes.length === 0"
289+
class="text-grey-8 q-pa-md"
290+
role="status"
291+
>
292+
No competencies found.
293+
</div>
287294
<q-tree
288295
:nodes="treeNodes"
289296
node-key="competencyId"
290297
v-model:expanded="expanded"
291298
dense
292-
v-if="loaded"
299+
v-if="loaded && treeNodes.length > 0"
293300
ref="tree"
294301
>
295302
<template #default-header="prop">

VueApp/src/CTS/pages/ManageDomains.vue

Lines changed: 9 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -66,41 +66,34 @@ getDomains()
6666
method="post"
6767
@submit="save"
6868
>
69-
<div class="row items-center">
70-
<span class="col col-md-2 col-lg-1">Domain:</span>
69+
<div class="row q-gutter-sm q-mb-sm">
7170
<q-input
7271
outlined
7372
dense
74-
type="text"
75-
name="name"
73+
label="Domain"
7674
v-model="domain.name"
77-
size="30"
7875
maxlength="250"
79-
class="col col-md-5 col-lg-3"
76+
class="col-12 col-md-5 col-lg-3"
8077
/>
81-
</div>
82-
<div class="row items-center">
83-
<span class="col col-md-2 col-lg-1">Order:</span>
8478
<q-input
8579
outlined
8680
dense
81+
label="Order"
8782
type="number"
88-
name="order"
8983
v-model="domain.order"
9084
step="1"
91-
class="col col-1"
85+
class="col-4 col-md-1"
9286
/>
9387
</div>
94-
<div class="row items-start">
95-
<span class="col col-md-2 col-lg-1 q-pt-sm">Description:</span>
88+
<div class="row q-mb-sm">
9689
<q-input
9790
outlined
9891
dense
92+
label="Description"
9993
type="textarea"
100-
name="description"
10194
v-model="domain.description"
102-
class="col col-md-5 col-lg-3"
103-
></q-input>
95+
class="col-12 col-md-5 col-lg-3"
96+
/>
10497
</div>
10598
<div class="row q-mt-sm">
10699
<q-btn

0 commit comments

Comments
 (0)