Skip to content

Commit eee8d10

Browse files
committed
chore(quality): materialize CalculateWeightedAverage rows once
Carry-over from the analyzer-driven cleanup batch (PR 3). The materialization fix targets the helper extracted in d12711e — that helper doesn't exist in PR 3's base, so the fix moves here.
1 parent f186386 commit eee8d10

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

web/Areas/Effort/Services/EvaluationReportService.cs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -363,8 +363,9 @@ private static EvalSummaryReport BuildEvalSummaryReport(EvalSummaryReport report
363363
/// </summary>
364364
private static decimal CalculateWeightedAverage(IEnumerable<EvalRawRow> rows)
365365
{
366-
var totalPts = rows.Sum(r => r.N5 * 5m + r.N4 * 4m + r.N3 * 3m + r.N2 * 2m + r.N1 * 1m);
367-
var totalResponses = rows.Sum(r => r.N5 + r.N4 + r.N3 + r.N2 + r.N1);
366+
var rowList = rows.ToList();
367+
var totalPts = rowList.Sum(r => r.N5 * 5m + r.N4 * 4m + r.N3 * 3m + r.N2 * 2m + r.N1 * 1m);
368+
var totalResponses = rowList.Sum(r => r.N5 + r.N4 + r.N3 + r.N2 + r.N1);
368369
return totalResponses > 0 ? Math.Round(totalPts / totalResponses, 2) : 0m;
369370
}
370371

0 commit comments

Comments
 (0)