Merge pull request #177 from ucdavis/refactor/dead-code-and-shared-chrome

PR 4: refactor: dead-code removal + shared chrome extraction

Author: rlorenzo

VueApp/src/CAHFS/assets/cahfs.css

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router as CAHFSRouter }

VueApp/src/CAHFS/router/index.ts

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router as cmsRouter }

VueApp/src/CMS/assets/cms.css

@@ -1,15 +1,9 @@
-import { createRouter, createWebHistory } from "vue-router"
+import { createSpaRouter } from "@/shared/createSpaRouter"
 import { routes } from "./routes"
 import { useRequireLogin } from "@/composables/RequireLogin"
 import { checkHasOnePermission } from "@/composables/CheckPagePermission"
-import { useRouteFocus } from "@/composables/use-route-focus"
 
-const baseUrl = import.meta.env.VITE_VIPER_HOME
-const router = createRouter({
-    scrollBehavior: () => ({ left: 0, top: 0 }),
-    history: createWebHistory(baseUrl),
-    routes,
-})
+const router = createSpaRouter(routes)
 
 router.beforeEach(async (to) => {
     const { requireLogin } = useRequireLogin(to)
@@ -25,6 +19,4 @@ router.beforeEach(async (to) => {
     }
 })
 
-useRouteFocus(router)
-
 export { router }

VueApp/src/CMS/router/index.ts

@@ -272,22 +272,19 @@ export type {
     LegacyComptency,
     Epa,
     Assessment,
-    StudentEpaFormData,
     Level,
     ServiceSelect,
     Service,
     Student,
     Person,
     Role,
     Bundle,
-    BundleRole,
     BundleCompetency,
     CompetencyBundleAssociation,
     BundleCompetencyAddUpdate,
     BundleCompetencyGroup,
     Milestone,
     MilestoneLevel,
-    MilestoneLevelUpdate,
     Course,
     Session,
     Term,

VueApp/src/CTS/pages/CourseList.vue

@@ -15,11 +15,11 @@
 }
 
 /* Shared typography for schedule pages */
-h3 {
+.clinical-scheduler-container h3 {
     color: var(--ucdavis-black-80);
-    font-size: 16px;
-    margin-top: 20px;
-    margin-bottom: 10px;
+    font-size: 1rem;
+    margin-top: 1.25rem;
+    margin-bottom: 0.625rem;
 }
 
 .schedule-note {
@@ -38,8 +38,8 @@ h3 {
 
 /* Mobile responsiveness for main headers */
 @media (max-width: 768px) {
-    h2 {
-        font-size: 18px;
+    .clinical-scheduler-container h2 {
+        font-size: 1.125rem;
     }
 
     /* Shared mobile badge positioning */
@@ -93,7 +93,7 @@ h3 {
 }
 
 @media (max-width: 480px) {
-    h2 {
-        font-size: 16px;
+    .clinical-scheduler-container h2 {
+        font-size: 1rem;
     }
 }

VueApp/src/CTS/pages/MyAssessmentCharts.vue

@@ -176,7 +176,7 @@ function isNewlyAdded(assignmentId: number): boolean {
     return newlyAddedAssignments.value.has(assignmentId)
 }
 
-export interface WeekAssignment {
+interface WeekAssignment {
     id: number
     displayName: string
     isPrimary?: boolean
@@ -355,8 +355,6 @@ const cardClasses = computed(() => {
 </script>
 
 <style scoped>
-@import url("@/styles/colors.css");
-
 .week-schedule-card {
     max-width: 280px;
     min-width: 200px;