Skip to content

Commit f83c4b4

Browse files
committed
refactor: remove unused type exports (Phase 3)
- Drop 42 dead re-exports from Effort/types/index.ts barrel: types passed through but no consumer imported them via the barrel. - Drop 15 types each from report-types.ts and report-types-extended.ts and 9 from harvest-types.ts: row/group intermediates used only as property types within the same module; now file-local. - Drop 8 service response types from api-responses.ts and parallel cleanups in instructor-schedule-service.ts, clinician-service.ts, ClinicalScheduler/types/index.ts, rotation-types.ts. - Drop singletons: PageInitialData, PermissionErrorType, PermissionsGetters, UpdateRotationParams, EffortColumnOptions, HarvestProgressEvent, DataHygieneSummaryDto, EvalCourseInfoDto, EmailFailure, ValidationErrors, 3 CTS types. - Fix BreadCrumb duplicate-export across ViperLayout.vue and ViperLayoutSimple.vue by making the local-only type file-private in both. - WeekAssignment, WeekItem, ViewMode dropped to file-local in their component files. - UserInfo stays exported — TypeScript requires it externally nameable because ProfilePic.vue's script-setup exposes store values typed with it.
1 parent 1cb4c3e commit f83c4b4

24 files changed

Lines changed: 15 additions & 154 deletions

VueApp/src/CTS/types/index.ts

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -272,22 +272,19 @@ export type {
272272
LegacyComptency,
273273
Epa,
274274
Assessment,
275-
StudentEpaFormData,
276275
Level,
277276
ServiceSelect,
278277
Service,
279278
Student,
280279
Person,
281280
Role,
282281
Bundle,
283-
BundleRole,
284282
BundleCompetency,
285283
CompetencyBundleAssociation,
286284
BundleCompetencyAddUpdate,
287285
BundleCompetencyGroup,
288286
Milestone,
289287
MilestoneLevel,
290-
MilestoneLevelUpdate,
291288
Course,
292289
Session,
293290
Term,

VueApp/src/ClinicalScheduler/components/ScheduleView.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ import { computed, ref } from "vue"
7979
import { useKeyModifier, useEventListener } from "@vueuse/core"
8080
import WeekCell from "./WeekCell.vue"
8181
82-
export interface WeekItem {
82+
interface WeekItem {
8383
weekId: number
8484
weekNumber: number
8585
dateStart: string
@@ -104,7 +104,7 @@ export interface ScheduleSemester {
104104
weeks: (WeekItem & { dateEnd: string })[]
105105
}
106106
107-
export type ViewMode = "rotation" | "clinician"
107+
type ViewMode = "rotation" | "clinician"
108108
109109
// Helper callable type to avoid parameter-name linting within Props
110110
interface WeekFn<T> {

VueApp/src/ClinicalScheduler/components/WeekCell.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ function isNewlyAdded(assignmentId: number): boolean {
176176
return newlyAddedAssignments.value.has(assignmentId)
177177
}
178178
179-
export interface WeekAssignment {
179+
interface WeekAssignment {
180180
id: number
181181
displayName: string
182182
isPrimary?: boolean

VueApp/src/ClinicalScheduler/services/clinician-service.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -236,13 +236,4 @@ interface ClinicianRotationSummary {
236236
}[]
237237
}
238238

239-
export {
240-
ClinicianService,
241-
type Clinician,
242-
type ClinicianRotationItem,
243-
type ScheduleRotation,
244-
type ScheduleWeek,
245-
type ScheduleBySemester,
246-
type ClinicianScheduleData,
247-
type ClinicianRotationSummary,
248-
}
239+
export { ClinicianService, type Clinician, type ClinicianScheduleData }

VueApp/src/ClinicalScheduler/services/instructor-schedule-service.ts

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -262,13 +262,4 @@ interface AuditEntry {
262262

263263
// ApiResult moved to shared types/api.ts
264264

265-
export {
266-
InstructorScheduleService,
267-
type InstructorScheduleRequest,
268-
type InstructorScheduleResponse,
269-
type RemoveInstructorResult,
270-
type ScheduleConflict,
271-
type SetPrimaryEvaluatorRequest,
272-
type AuditEntry,
273-
type ApiResult,
274-
}
265+
export { InstructorScheduleService }

VueApp/src/ClinicalScheduler/services/page-data-service.ts

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -103,5 +103,3 @@ export class PageDataService {
103103
return result.availableGradYears
104104
}
105105
}
106-
107-
export type { PageInitialData }

VueApp/src/ClinicalScheduler/services/permission-service.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -258,4 +258,4 @@ class PermissionService {
258258
// Export singleton instance and class
259259
const permissionService = new PermissionService()
260260

261-
export { permissionService, PermissionService, type PermissionErrorType }
261+
export { permissionService, PermissionService }

VueApp/src/ClinicalScheduler/stores/permissions-utils.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ import type { Service } from "../types"
55
* Interface defining the getters used by permission utilities.
66
* Provides typed access to computed values from the permissions store.
77
*/
8-
export interface PermissionsGetters {
8+
interface PermissionsGetters {
99
editableServices: {
1010
value: Service[]
1111
}

VueApp/src/ClinicalScheduler/types/api-responses.ts

Lines changed: 1 addition & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -77,14 +77,4 @@ type ConflictCheckApiResult = ApiResult<ScheduleConflictResponse>
7777
// 204 No Content
7878
type RemoveInstructorApiResult = ApiResult<void>
7979

80-
export {
81-
type ErrorResponse,
82-
type ApiError,
83-
type InstructorScheduleResponse,
84-
type AddInstructorResponse,
85-
type ScheduleConflictResponse,
86-
type SuccessResponse,
87-
type AddInstructorApiResult,
88-
type ConflictCheckApiResult,
89-
type RemoveInstructorApiResult,
90-
}
80+
export { type ApiError }

VueApp/src/ClinicalScheduler/types/index.ts

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -97,9 +97,4 @@ export {
9797
type ServicePermissionCheck,
9898
type RotationPermissionCheck,
9999
type InstructorSchedulePermissionCheck,
100-
type InstructorScheduleRequest,
101-
type InstructorScheduleResponse,
102-
type ScheduleConflict,
103-
type SetPrimaryEvaluatorRequest,
104-
type AuditEntry,
105100
}

0 commit comments

Comments
 (0)