fix: only apply instructor changes on sectiongroup head

Author: jaroldwong

app/registrarReconciliationReport/controllers/registrarReconciliationReportCtrl.js

@@ -84,22 +84,27 @@ class registrarReconciliationReportCtrl {
 				.filter((section) => section.dwHasChanges)
 				.forEach((section) => {
 					section.instructors.forEach((instructor) => {
+						if (!section.groupHead) {
+							return;
+						}
+						const sectionUniqueKey = isNaN(Number(section.sequenceNumber)) ?  section.uniqueKey.slice(0, -2) : section.uniqueKey;
+
 						if (instructor.noRemote) {
 							updates.push({
 								section: section,
 								property: 'unassign',
 								instructor: instructor,
-								uniqueKey: section.uniqueKey,
+								uniqueKey: sectionUniqueKey,
 								isChecked: true,
 							});
 						}
-						
+
 						if (instructor.noLocal) {
 							updates.push({
 								section: section,
 								property: 'assign',
 								instructor: instructor,
-								uniqueKey: section.uniqueKey,
+								uniqueKey: sectionUniqueKey,
 								isChecked: true,
 							});
 						}

app/registrarReconciliationReport/services/registrarReconciliationReportStateService.js

@@ -197,11 +197,11 @@ class RegistrarReconciliationReportStateService {
 						sections.ids.sort();
 
 						// Flag the first section in a sectionGroup as a groupHead
-						var uniqSectionGroupKeys = [];
+						var groupHeadIds = new Set();
 						sections.ids.forEach(function (id) {
-							var uniqueKey = sectionList[id].uniqueKey;
-							if (uniqSectionGroupKeys.indexOf(uniqueKey) < 0) {
-								uniqSectionGroupKeys.push(uniqueKey);
+							const sectionGroupId = sectionList[id].sectionGroupId;
+							if (!groupHeadIds.has(sectionGroupId)) {
+								groupHeadIds.add(sectionGroupId);
 								sectionList[id].groupHead = true;
 							}
 						});