Skip to content

Commit 2b92434

Browse files
committed
Comment only changes to clarify the state of the temporary named excludes in
linting targets and their eventual removal once we have addressed the code scan issues they currently trigger.
1 parent 917a49a commit 2b92434

2 files changed

Lines changed: 7 additions & 5 deletions

File tree

Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -61,6 +61,7 @@ style-check-python:
6161
@$(LOCAL_PYTHON_BIN) -m black $(LINT_ENFORCE_DIRS) --check
6262
@$(LOCAL_PYTHON_BIN) -m isort $(LINT_ENFORCE_DIRS) --check-only
6363

64+
# NOTE: pylint and ruff use pyproject.toml to temporarily exclude a few paths
6465
.PHONY: lint-python
6566
lint-python:
6667
@$(LOCAL_PYTHON_BIN) -m pylint $(LINT_ENFORCE_DIRS) --errors-only

pyproject.toml

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,16 @@
11
# Project wide settings including tooling.
22

33
# Linting tools
4-
# TODO: fix CodeQL errors in symlinked files and disable extend-exclude+skip
4+
5+
# TODO: fix CodeQL errors and disable temporary named files with NOTEs below
56

67
[tool.black]
78
line-length = 80
89
exclude = '''
910
tests/data/
1011
| tests/fixture/
1112
'''
12-
# NOTE: the following regex matches must be kept in sync with isort skip
13+
# NOTE: the following temporay excludes must be kept in sync between tools
1314
extend-exclude = '''
1415
bin/checkconf.py
1516
| bin/createresource.py
@@ -24,7 +25,7 @@ extend-exclude = '''
2425
profile = "black"
2526
line_length = 80
2627
skip_glob = [".git/*", "tests/data/*", "tests/fixture/*"]
27-
# NOTE: the following paths must be kept in sync with black extend-exclude
28+
# NOTE: the following temporay excludes must be kept in sync between tools
2829
skip = [
2930
"bin/checkconf.py",
3031
"bin/createresource.py",
@@ -41,7 +42,7 @@ ignore-pattern = '''
4142
tests/data/
4243
| tests/fixture/
4344
'''
44-
# NOTE: the following paths must be kept in sync with black extend-exclude
45+
# NOTE: the following temporay excludes must be kept in sync between tools
4546
ignore-paths = [
4647
"bin/checkconf.py",
4748
"bin/createresource.py",
@@ -55,7 +56,7 @@ ignore-paths = [
5556
[tool.ruff]
5657
line-length = 80
5758
exclude = [".git/", "tests/data/", "tests/fixture/"]
58-
# NOTE: the following regex matches must be kept in sync with isort skip
59+
# NOTE: the following temporay excludes must be kept in sync between tools
5960
extend-exclude = [
6061
"bin/checkconf.py",
6162
"bin/createresource.py",

0 commit comments

Comments
 (0)