Skip to content

Commit c2f8d39

Browse files
committed
Rename reqtimeout to antislowloris to address review feedback about possible
name collisions.
1 parent d9401f5 commit c2f8d39

2 files changed

Lines changed: 8 additions & 8 deletions

File tree

mig/install/apache-mimic-deb-template.conf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ __JUPYTER_COMMENTED__ LoadModule lbmethod_byrequests_module modules/mod_lbmethod
8181
__HSTS_COMMENTED__ LoadModule headers_module modules/mod_headers.so
8282

8383
# Optional resource hogging prevention if requested (for mod reqtimeout)
84-
__REQTIMEOUT_COMMENTED__ LoadModule reqtimeout_module modules/mod_reqtimeout.so
84+
__ANTISLOWLORIS_COMMENTED__ LoadModule reqtimeout_module modules/mod_reqtimeout.so
8585

8686
# Apparently we need this mime setup on Redhat to just run apache
8787
TypesConfig /etc/mime.types

mig/shared/install.py

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -382,7 +382,7 @@ def generate_confs(
382382
enable_jupyter=False,
383383
enable_cloud=False,
384384
enable_hsts=True,
385-
enable_reqtimeout=False,
385+
enable_antislowloris=False,
386386
enable_vhost_certs=False,
387387
enable_verify_certs=False,
388388
enable_seafile=False,
@@ -712,7 +712,7 @@ def _generate_confs_prepare(
712712
enable_jupyter,
713713
enable_cloud,
714714
enable_hsts,
715-
enable_reqtimeout,
715+
enable_antislowloris,
716716
enable_vhost_certs,
717717
enable_verify_certs,
718718
enable_seafile,
@@ -972,7 +972,7 @@ def _generate_confs_prepare(
972972
user_dict['__ENABLE_JUPYTER__'] = "%s" % enable_jupyter
973973
user_dict['__ENABLE_CLOUD__'] = "%s" % enable_cloud
974974
user_dict['__ENABLE_HSTS__'] = "%s" % enable_hsts
975-
user_dict['__ENABLE_REQTIMEOUT__'] = "%s" % enable_reqtimeout
975+
user_dict['__ENABLE_ANTISLOWLORIS__'] = "%s" % enable_antislowloris
976976
user_dict['__ENABLE_VHOST_CERTS__'] = "%s" % enable_vhost_certs
977977
user_dict['__ENABLE_VERIFY_CERTS__'] = "%s" % enable_verify_certs
978978
user_dict['__ENABLE_SEAFILE__'] = "%s" % enable_seafile
@@ -1368,11 +1368,11 @@ def _generate_confs_prepare(
13681368
else:
13691369
user_dict['__HSTS_COMMENTED__'] = '#'
13701370

1371-
# Enable reqtimeout module to limit resource use if explicitly requested
1372-
if user_dict['__ENABLE_REQTIMEOUT__'].lower() == 'true':
1373-
user_dict['__REQTIMEOUT_COMMENTED__'] = ''
1371+
# Enable apache reqtimeouts to kick idle clients if explicitly requested
1372+
if user_dict['__ENABLE_ANTISLOWLORIS__'].lower() == 'true':
1373+
user_dict['__ANTISLOWLORIS_COMMENTED__'] = ''
13741374
else:
1375-
user_dict['__REQTIMEOUT_COMMENTED__'] = '#'
1375+
user_dict['__ANTISLOWLORIS_COMMENTED__'] = '#'
13761376

13771377
# Enable vhost-specific certificates only if explicitly requested
13781378
if user_dict['__ENABLE_VHOST_CERTS__'].lower() == 'true':

0 commit comments

Comments
 (0)