Silence noise when running the test suite.#505
Merged
jonasbardino merged 4 commits intonextfrom Apr 13, 2026
Merged
Conversation
albu-diku
force-pushed
the
test/silence-noise-from-legacy-tests
branch
2 times, most recently
from
2f0ad61 to
7e1cdcc
Compare
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
reviewed
Apr 7, 2026
jonasbardino
added
the
test-only
Contributor
Author
|
@jonasbardino will do the pass on renaming the methods themselves - thanks for the look :) |
When the testcore boilerplate was copied for other legacy tests the main methods were not made to fit to the same extent, particularly around the print override. Meanwhile, we now use only PY3 which allows shadowing the print function. So, use this to avoid filling the console with arbitrary messages while the tests are run. While here make things consistent - always pass in a test configuration, use the passed in value and try to consistently use legacy main naming.
albu-diku
force-pushed
the
test/silence-noise-from-legacy-tests
branch
from
f713bca to
3a824bf
Compare
Added the missing class docstring. Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Added the missing class docstring. Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
Adjust docstring to generic form. Signed-off-by: Jonas Bardino <bardino@science.ku.dk>
jonasbardino
approved these changes
Apr 13, 2026
Contributor
jonasbardino
left a comment
jonasbardino
left a comment
There was a problem hiding this comment.
Thanks. I've added some missing class docstring and will proceed with merge.
On a side note please look into signing your commits with an ssh or gpg key as required now. You can see them show up with a Verified marker here once it works.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the testcore boilerplate was copied for other legacy tests the main methods were not made to fit to the same extent, particularly around the print override. Meanwhile, we now use only PY3 which allows shadowing the print function. So, use this to now stop filling the console with arbitrary messags while the tests are run. While here make things consistent - always pass in a test configuration, use the passed in value and align naming/messages.