Rework OpenID service cookie handling#521
Merged
jonasbardino merged 4 commits intonextfrom Apr 21, 2026
Merged
Conversation
…l issues hightligthed by code scans. Namely, encode and decode cookie values to base64.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jonasbardino
changed the title
protection against cookie or header splitting issues even though input validation should already prevent it.
Contributor
Author
|
The lint issue is old and a duplicate of the one from #338 . |
Contributor
Author
|
Tested to be functional on one of our dev/test deployments. |
jonasbardino
added
stale check errors
Martin-Rehr
reviewed
Apr 21, 2026
Martin-Rehr
approved these changes
Apr 21, 2026
Contributor
Martin-Rehr
left a comment
Martin-Rehr
left a comment
There was a problem hiding this comment.
Approved when typo is fixed
Most likely from a stray 'i' to enter interactive mode in vim(diff).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rework OpenID service cookie handling to address a couple of potential issues highlighted by code scans. Namely, encode and decode cookie values to base64.
We need to consider issues like these until we complete an OpenID Connect replacement.